From: "mjw at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/10458] uaddr() returns one past current instruction for uprobes
Date: Fri, 31 Jul 2009 18:56:00 -0000 [thread overview]
Message-ID: <20090731185644.14077.qmail@sourceware.org> (raw)
In-Reply-To: <20090729111010.10458.mjw@redhat.com>
------- Additional Comments From mjw at redhat dot com 2009-07-31 18:56 -------
(In reply to comment #11)
> Looks good, but keep in mind that the (corrected) IP when you're in a kretprobe
> or uretprobe handler is just the address of the return-probe trampoline.
This was mostly to make sure that we are always at the actual probe address and
not accidentally one past (possibly in the middle of the actual instruction, and
in the worse case just one past the end of the function).
The next layer/level deals with the actual symbol/unwind resolving. But we might
indeed always have to special case the [ku]retprobe case by checking CONTEXT->pi
being set anyway. If so, then we might indeed never need the actual address in
the first place. Thanks for the reminder. I'll think about it.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=10458
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
prev parent reply other threads:[~2009-07-31 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 11:10 [Bug uprobes/10458] New: " mjw at redhat dot com
2009-07-29 14:52 ` [Bug uprobes/10458] " fche at redhat dot com
2009-07-29 16:00 ` mhiramat at redhat dot com
2009-07-29 16:17 ` jkenisto at us dot ibm dot com
2009-07-29 17:22 ` jkenisto at us dot ibm dot com
2009-07-29 22:32 ` mjw at redhat dot com
2009-07-29 22:38 ` jistone at redhat dot com
2009-07-29 23:51 ` fche at redhat dot com
2009-07-30 0:28 ` jistone at redhat dot com
2009-07-30 14:44 ` mjw at redhat dot com
2009-07-31 18:10 ` mjw at redhat dot com
2009-07-31 18:29 ` jkenisto at us dot ibm dot com
2009-07-31 18:56 ` mjw at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090731185644.14077.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).