* [Bug tapsets/10204] New: Place userspace markers in systemtap itself
@ 2009-05-26 21:23 jistone at redhat dot com
2009-05-29 17:41 ` [Bug tapsets/10204] " ksebasti at redhat dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: jistone at redhat dot com @ 2009-05-26 21:23 UTC (permalink / raw)
To: systemtap
Perhaps we should eat our own dogfood, and start placing userspace markers in
our own programs. Some simple candidates off the top of my head:
= stap
- start/end of each phase
- launching other processes [stap_system()]
- various cache activity
= staprun
- loading/unloading the module
= stapio
- send/recv control messages
- recv data messages
Not all of these would necessarily need markers, but they could all go into a
stap.* tapset in whatever form makes sense.
--
Summary: Place userspace markers in systemtap itself
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: jistone at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=10204
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tapsets/10204] Place userspace markers in systemtap itself
2009-05-26 21:23 [Bug tapsets/10204] New: Place userspace markers in systemtap itself jistone at redhat dot com
@ 2009-05-29 17:41 ` ksebasti at redhat dot com
2009-07-31 20:56 ` ksebasti at redhat dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ksebasti at redhat dot com @ 2009-05-29 17:41 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|systemtap at sources dot |ksebasti at redhat dot com
|redhat dot com |
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=10204
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tapsets/10204] Place userspace markers in systemtap itself
2009-05-26 21:23 [Bug tapsets/10204] New: Place userspace markers in systemtap itself jistone at redhat dot com
2009-05-29 17:41 ` [Bug tapsets/10204] " ksebasti at redhat dot com
@ 2009-07-31 20:56 ` ksebasti at redhat dot com
2009-07-31 22:18 ` jistone at redhat dot com
2009-08-05 19:23 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: ksebasti at redhat dot com @ 2009-07-31 20:56 UTC (permalink / raw)
To: systemtap
------- Additional Comments From ksebasti at redhat dot com 2009-07-31 20:56 -------
Committed as of 67a31a9f57db3f8108e31522b3cf5a6d7d604f22. After talking it over
a bit with fche, due to how the tapsets are processed (at make install time vs
configure time) I commented out the stapio probe in the tapset for now. The
corresponding static marker is still committed however.
I'll leave the bug open but reassign it.
(In reply to comment #8)
> > probe staprun.send_control_message =
> process("/usr/local/bin/staprun").mark("send__ctlmsg") {
>
> Isn't this probe really in stapio?
The marker is in the send_request function, which is in
runtime/staprun/common.c, so I guess not :)
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|ksebasti at redhat dot com |systemtap at sources dot
| |redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=10204
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tapsets/10204] Place userspace markers in systemtap itself
2009-05-26 21:23 [Bug tapsets/10204] New: Place userspace markers in systemtap itself jistone at redhat dot com
2009-05-29 17:41 ` [Bug tapsets/10204] " ksebasti at redhat dot com
2009-07-31 20:56 ` ksebasti at redhat dot com
@ 2009-07-31 22:18 ` jistone at redhat dot com
2009-08-05 19:23 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: jistone at redhat dot com @ 2009-07-31 22:18 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jistone at redhat dot com 2009-07-31 22:18 -------
> (In reply to comment #8)
> > > probe staprun.send_control_message =
> > process("/usr/local/bin/staprun").mark("send__ctlmsg") {
> >
> > Isn't this probe really in stapio?
>
> The marker is in the send_request function, which is in
> runtime/staprun/common.c, so I guess not :)
Here "common" means shared by both stapio and staprun, so the mark should
actually manifest in both. staprun's use of send_request is only for loading
kernel module relocations; stapio's messages are more interesting IMO.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=10204
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tapsets/10204] Place userspace markers in systemtap itself
2009-05-26 21:23 [Bug tapsets/10204] New: Place userspace markers in systemtap itself jistone at redhat dot com
` (2 preceding siblings ...)
2009-07-31 22:18 ` jistone at redhat dot com
@ 2009-08-05 19:23 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: fche at redhat dot com @ 2009-08-05 19:23 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-08-05 19:23 -------
committed
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=10204
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-05 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-26 21:23 [Bug tapsets/10204] New: Place userspace markers in systemtap itself jistone at redhat dot com
2009-05-29 17:41 ` [Bug tapsets/10204] " ksebasti at redhat dot com
2009-07-31 20:56 ` ksebasti at redhat dot com
2009-07-31 22:18 ` jistone at redhat dot com
2009-08-05 19:23 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).