[Bug translator/10486] New: raise default MAXSTRINGLEN on 64-bit hosts

[Bug translator/10486] New: raise default MAXSTRINGLEN on 64-bit hosts

[fche at redhat dot com]

On a 64-bit host, a modest backtrace can easily outgrow a MAXSTRINGLEN-sized
string buffer.  One easy hack around this is to raise MAXSTRINGLEN to double
or quadruple the default size, with the assumption that memory consumption is
not as tight on such machines anyway.

-- 
           Summary: raise default MAXSTRINGLEN on 64-bit hosts
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10486

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10486] raise default MAXSTRINGLEN on 64-bit hosts

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 21:20 -------
yes please!

We already have multiple testcase in our own testsuite that have to raise the
MAXSTRINGLEN just to have enough space for a couple of backtrace entries.

It would even be good if we could raise the length for 32 bit arches also. For
example for tracing some java stuff you easily exceed 128 characters just trying
to store or report a method signature (an example from the standard library:
'java/util/WeakHashMap$Entry.<init>(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/ref/ReferenceQueue;ILjava/util/WeakHashMap$Entry;)V')

I thought one reason for the small limit was that we used to stack allocate
strings in some places. But we don't do that anymore.

If we could raise the limit for 32bit to 256 and for 64bit to 512 chars that
would be great.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10486

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10486] raise default MAXSTRINGLEN on 64-bit hosts

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 21:30 -------
Created an attachment (id=4117)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4117&action=view)
Raise limits to 256/512

testing a patch

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10486

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10486] raise default MAXSTRINGLEN on 64-bit hosts

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 22:06 -------
commit 1eed9afca1a408fb35e39b9e935011b7b8d3c7ba
Author: Mark Wielaard <mjw@redhat.com>
Date:   Fri Aug 7 00:01:04 2009 +0200

    PR10486 Raise default MAXSTRINGLEN.
    
    * translate.cxx (translate_pass): Raise MAXSTRINGLEN to 256 for 32bit arches
      and to 512 for 64bit arches.
    * testsuite/systemtap.context/backtrace.tcl: Don't set MAXSTRINGLEN.
    * testsuite/systemtap.exelib/ustack.tcl: Likewise.
    * testsuite/systemtap.string/str_replace.exp: Explicitly set MAXSTRINGLEN.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10486

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.