[Bug translator/10491] New: Compilation error on running para-callgraph.stp

[Bug translator/10491] New: Compilation error on running para-callgraph.stp

[maranp at linux dot vnet dot ibm dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

On running the following stap command of git commit release-0.9.9-91-g034ce93, a
compilation error is thrown as shown below.
stap -v -v para-callgraph.stp 'kernel.function("*@fs/proc*.c")'
'kernel.function("vfs_read")' -c "cat /proc/sys/vm/*"

Pass 3: translated to C into
"/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c" in
1260usr/80sys/1334real ms.
Running make -C "/lib/modules/2.6.31-rc4jul29/build" M="/tmp/stapDS4xhd" modules
>/dev/null
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c: In function
‘enter_kprobe_probe’:
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c:13106: error:
invalid lvalue in assignment
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c:13108: error:
invalid lvalue in assignment
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c: In function
‘enter_kretprobe_probe’:
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c:13227: error:
invalid lvalue in assignment
/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.c:13229: error:
invalid lvalue in assignment
make[1]: *** [/tmp/stapDS4xhd/stap_31d681ff74d5982722c0627af8a709dd_110179.o]
Error 1
make: *** [_module_/tmp/stapDS4xhd] Error 2
Error 2 No such file or directory
Pass 4: compiled C into "stap_31d681ff74d5982722c0627af8a709dd_110179.ko" in
4360usr/670sys/5064real ms.
Pass 4: compilation failed.  Try again with another '--vp 0001' option.
Running rm -rf /tmp/stapDS4xhd

-- 
           Summary: Compilation error on running para-callgraph.stp
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: maranp at linux dot vnet dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 07:34 -------
Which architecture?
I assume ia64 and/or s390x. If so, I might be working on a fix already.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2009-08-06 07:48 -------
s390x.

Will this and the nss fix necessitate a 0.9.9.1 or such?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp ia64/s390

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 08:56 -------
Could you try out the patch I just committed?

commit 3d9889977397098d14c5be50f1dfef1c3eeb508f
Author: Mark Wielaard <mjw@redhat.com>
Date:   Thu Aug 6 10:41:46 2009 +0200

    PR10491 Don't assign to REG_IP if it isn't an lvalue (s390 and ia64).
    
    To fixup REG_IP to show the correct value after a [ku]probe trap we
    assigned the address of the actual instruction pointer of the probed
    instruction. That doesn't work on architectures, s390 and ia64, where
    REG_IP is not a simple lvalue. Just don't try to fixup the address in
    those cases. If this isn't enough, the uprobe_stmt_num.exp testcase
    will point this out.
    
    * runtime/regs.h: Define REG_IP_LVALUE for x86_64, i386, powerpc64 and arm.
    * tapsets.cxx (dwarf_derived_probe_group::emit_module_decls): Only fixup
      REG_IP when REG_IP_LVALUE is defined.
      (uprobe_derived_probe_group::emit_module_decls): Likewise.
      (kprobe_derived_probe_group::emit_module_decls): Likewise.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Compilation error on running|Compilation error on running
                   |para-callgraph.stp          |para-callgraph.stp ia64/s390


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp ia64/s390

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 08:59 -------
(In reply to comment #2)
> Will this and the nss fix necessitate a 0.9.9.1 or such?

If the fix works then that would be nice imho. But maybe wait till we have
collected more test results and maybe more fixlets.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp ia64/s390

[maranp at linux dot vnet dot ibm dot com]

------- Additional Comments From maranp at linux dot vnet dot ibm dot com  2009-08-06 09:55 -------
I tested commit 3d9889977397098d14c5be50f1dfef1c3eeb508f
and the command gets executed successfully. Thank you.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10491] Compilation error on running para-callgraph.stp ia64/s390

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-08-06 09:57 -------
Thanks for testing.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10491

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.