From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22399 invoked by alias); 30 Aug 2009 01:25:30 -0000 Received: (qmail 22362 invoked by uid 22791); 30 Aug 2009 01:25:29 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.150) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 01:25:25 +0000 Received: by ey-out-1920.google.com with SMTP id 5so637577eyb.24 for ; Sat, 29 Aug 2009 18:25:23 -0700 (PDT) Received: by 10.210.101.10 with SMTP id y10mr3342671ebb.60.1251595523044; Sat, 29 Aug 2009 18:25:23 -0700 (PDT) Received: from nowhere (ADijon-552-1-25-198.w92-138.abo.wanadoo.fr [92.138.160.198]) by mx.google.com with ESMTPS id 7sm1179907eyb.4.2009.08.29.18.25.21 (version=SSLv3 cipher=RC4-MD5); Sat, 29 Aug 2009 18:25:22 -0700 (PDT) Received: by nowhere (nbSMTP-1.00) for uid 1000 (using TLSv1/SSLv3 with cipher RC4-MD5 (128/128 bits)) fweisbec@gmail.com; Sun, 30 Aug 2009 03:25:22 +0200 (CEST) Date: Sun, 30 Aug 2009 01:25:00 -0000 From: Frederic Weisbecker To: Masami Hiramatsu Cc: Ingo Molnar , lkml , systemtap , DLE , Ananth N Mavinakayanahalli Subject: Re: [PATCH -tip tracing/kprobes 1/6] kprobes/x86: Call BUG() when reentering probe into KPROBES_HIT_SS Message-ID: <20090830012519.GC387@nowhere> References: <20090827152539.GE6058@nowhere> <20090827172258.8246.61889.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090827172258.8246.61889.stgit@localhost.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00498.txt.bz2 On Thu, Aug 27, 2009 at 01:22:58PM -0400, Masami Hiramatsu wrote: > Call BUG() when a probe have been hit on the way of kprobe processing path, > because that kind of probes are currently unrecoverable (recovering it will > cause an infinit loop and stack overflow). > > The original code seems to assume that it will be caused by an int3 which > another subsystem inserted on out-of-line singlestep buffer if the hitting > probe is same as current probe. However, in that case, int3-hitting-address > is on the out-of-line buffer and should be different from first (current) > int3 address. > Thus, I decided to remove the code. > > I also removes arch_disarm_kprobe() because it will involve other stuffs > in text_poke(). > > Signed-off-by: Masami Hiramatsu > Cc: Frederic Weisbecker > Cc: Ananth N Mavinakayanahalli > Cc: Ingo Molnar Applied the six patches to git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git tracing/kprobes Thanks!