From: "mjw at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/10595] uprobe probes causes selinux failures
Date: Thu, 03 Sep 2009 20:13:00 -0000 [thread overview]
Message-ID: <20090903201324.18658.qmail@sourceware.org> (raw)
In-Reply-To: <20090903122458.10595.mjw@redhat.com>
------- Additional Comments From mjw at redhat dot com 2009-09-03 20:13 -------
Roland made the observation that a private mapping of a file as executable is
allowed and that you can create one through shmem_file_setup (which has as an
extra benefit that /proc/<pid>/maps shows the mapping as /uprobes/ssol). That
seems to work.
Currently testing this patch:
diff --git a/runtime/uprobes2/uprobes.c b/runtime/uprobes2/uprobes.c
index 07ad398..195a79b 100644
--- a/runtime/uprobes2/uprobes.c
+++ b/runtime/uprobes2/uprobes.c
@@ -1387,6 +1387,7 @@ static noinline unsigned long
uprobe_setup_ssol_vma(unsigned long nbytes)
unsigned long addr;
struct mm_struct *mm;
struct vm_area_struct *vma;
+ struct file *file;
BUG_ON(nbytes & ~PAGE_MASK);
if ((addr = find_old_ssol_vma()) != 0)
@@ -1403,8 +1404,8 @@ static noinline unsigned long
uprobe_setup_ssol_vma(unsigned long nbytes)
*/
vma = rb_entry(rb_last(&mm->mm_rb), struct vm_area_struct, vm_rb);
addr = vma->vm_end + PAGE_SIZE;
- addr = do_mmap_pgoff(NULL, addr, nbytes, PROT_EXEC,
- MAP_PRIVATE|MAP_ANONYMOUS, 0);
+ file = shmem_file_setup("uprobes/ssol", nbytes, VM_NORESERVE);
+ addr = do_mmap_pgoff(file, addr, nbytes, PROT_EXEC, MAP_PRIVATE, 0);
if (addr & ~PAGE_MASK) {
up_write(&mm->mmap_sem);
mmput(mm);
--
http://sourceware.org/bugzilla/show_bug.cgi?id=10595
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2009-09-03 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 12:25 [Bug uprobes/10595] New: uprobe return " mjw at redhat dot com
2009-09-03 14:18 ` [Bug uprobes/10595] " mjw at redhat dot com
2009-09-03 16:25 ` [Bug uprobes/10595] uprobe " mjw at redhat dot com
2009-09-03 17:44 ` jkenisto at us dot ibm dot com
2009-09-03 20:13 ` mjw at redhat dot com [this message]
2009-09-04 11:09 ` mjw at redhat dot com
2009-09-04 11:58 ` srikar at linux dot vnet dot ibm dot com
2009-09-04 17:11 ` jkenisto at us dot ibm dot com
2009-09-04 17:25 ` mjw at redhat dot com
2009-09-04 18:08 ` jkenisto at us dot ibm dot com
2009-09-07 11:38 ` mjw at redhat dot com
2009-09-08 12:26 ` srikar at linux dot vnet dot ibm dot com
2009-09-10 15:50 ` fche at redhat dot com
2009-09-14 18:51 ` fche at redhat dot com
2009-09-14 19:27 ` mjw at redhat dot com
2009-09-14 19:51 ` mjw at redhat dot com
2009-09-17 10:27 ` mjw at redhat dot com
2009-09-17 13:14 ` mjw at redhat dot com
2009-09-17 15:53 ` fche at redhat dot com
2009-09-18 15:08 ` mjw at redhat dot com
2009-12-14 14:19 ` mjw at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903201324.18658.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).