From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9987 invoked by alias); 11 Sep 2009 02:36:27 -0000 Received: (qmail 9979 invoked by uid 22791); 11 Sep 2009 02:36:27 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f224.google.com (HELO mail-ew0-f224.google.com) (209.85.219.224) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 02:36:22 +0000 Received: by ewy24 with SMTP id 24so58668ewy.22 for ; Thu, 10 Sep 2009 19:36:20 -0700 (PDT) Received: by 10.216.36.205 with SMTP id w55mr412425wea.110.1252636580334; Thu, 10 Sep 2009 19:36:20 -0700 (PDT) Received: from nowhere (ADijon-552-1-29-18.w92-138.abo.wanadoo.fr [92.138.164.18]) by mx.google.com with ESMTPS id 5sm867770eyf.10.2009.09.10.19.36.17 (version=SSLv3 cipher=RC4-MD5); Thu, 10 Sep 2009 19:36:19 -0700 (PDT) Received: by nowhere (nbSMTP-1.00) for uid 1000 (using TLSv1/SSLv3 with cipher RC4-MD5 (128/128 bits)) fweisbec@gmail.com; Fri, 11 Sep 2009 04:36:19 +0200 (CEST) Date: Fri, 11 Sep 2009 02:36:00 -0000 From: Frederic Weisbecker To: Daniel Walker Cc: Masami Hiramatsu , Steven Rostedt , Ingo Molnar , lkml , systemtap , DLE , Jim Keniston , Ananth N Mavinakayanahalli , Andi Kleen , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Lai Jiangshan , Li Zefan , Peter Zijlstra , Srikar Dronamraju , Tom Zanussi Subject: Re: [PATCH tracing/kprobes 3/7] tracing/kprobes: Cleanup kprobe tracer code. Message-ID: <20090911023615.GC16396@nowhere> References: <20090910235258.22412.29317.stgit@dhcp-100-2-132.bos.redhat.com> <20090910235322.22412.52525.stgit@dhcp-100-2-132.bos.redhat.com> <1252636411.30578.224.camel@desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252636411.30578.224.camel@desktop> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00669.txt.bz2 On Thu, Sep 10, 2009 at 07:33:31PM -0700, Daniel Walker wrote: > On Thu, 2009-09-10 at 19:53 -0400, Masami Hiramatsu wrote: > > Simplify trace_probe to remove an union, and remove some redundant wrappers. > > And also, cleanup create_trace_probe() function. > > > > > One single checkpatch issue in this one (whitespace).. The rest of the > patch set appears to be clean tho .. > > Daniel > Yep, no problem, I've fixed it while applying it. Thanks.