[Bug testsuite/10608] New: don't attempt 32-bit syscall tests if 32-bit devel environment not available

[Bug testsuite/10608] New: don't attempt 32-bit syscall tests if 32-bit devel environment not available

[fche at redhat dot com]

In testsuite/systemtap.syscall/test.tcl:run_one-test, if target_compile
failed, the rest of the test should be aborted with UNTESTED or somesuch.

-- 
           Summary: don't attempt 32-bit syscall tests if 32-bit devel
                    environment not available
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-09-07 08:23 -------
Created an attachment (id=4176)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4176&action=view)
simple patch to abort the test once compilation failed


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-09-07 08:48 -------
I am not sure I like this much since it hides stuff (32-on-64 did - and does -
show issues).

Also there are other tests that depend on 32-on-64 testing. e.g. exelib.exp and
utrace_syscall_args.exp

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-09-07 18:13 -------
(In reply to comment #2)
> I am not sure I like this much since it hides stuff (32-on-64 did - and does -
> show issues).

The proposed patch skips the tests if the 32-bit build environment is missing.
Under those circumstances, we would not get meaningful systemtap results
(since the tests couldn't be linked/run), so we lose nothing.

> Also there are other tests that depend on 32-on-64 testing. e.g. exelib.exp and
> utrace_syscall_args.exp

Right, and those should get the same treatment.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-09-10 03:29 -------
Created an attachment (id=4185)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4185&action=view)
Updated patch

Two parts are added.
1. Specify the detailed failed test information like 32/64-bit access
2. Do a little cleanup on  utrace_syscall_args.exp with same treatment.

A piece of example output after it.

Testing 32-bit clock
Executing on host: gcc ./systemtap.syscall/clock.c  -m32  -lm	-o
/home/wjhuang/systemtap/testsuite/staptestz25682/clock	  (timeout = 300)
/usr/local/bin/ld: cannot find -lgcc_s^M
collect2: ld returned 1 exit status^M
compiler exited with status 1
output is:
/usr/local/bin/ld: cannot find -lgcc_s^M
collect2: ld returned 1 exit status^M

32-bit clock : no corresponding devel environment found
UNTESTED: 32-bit clock

NB: Leave exelib.exp alone since it has suchlike termination once the
compilation failed and operates on different way.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4176 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-09-10 15:00 -------
How about putting all the dejagnu result calls (pass/fail/untested/etc.)
right into proc run_one_test{}, no longer returning magic strings for
result logging back in test_procedure{} ?  That would simplify things.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-09-11 05:35 -------
Created an attachment (id=4188)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4188&action=view)
patch v3

Put the logic things into proc run_one_test.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4185 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-09-14 07:10 -------
commit	38070723b06baf781ef18e2516e33e6bdbe18d8f

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10608] don't attempt 32-bit syscall tests if 32-bit devel environment not available

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-09-14 15:14 -------
Thanks.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10608

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.