From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9688 invoked by alias); 14 Sep 2009 19:51:45 -0000 Received: (qmail 9630 invoked by uid 48); 14 Sep 2009 19:51:34 -0000 Date: Mon, 14 Sep 2009 19:51:00 -0000 Message-ID: <20090914195134.9629.qmail@sourceware.org> From: "mjw at redhat dot com" To: systemtap@sources.redhat.com In-Reply-To: <20090903122458.10595.mjw@redhat.com> References: <20090903122458.10595.mjw@redhat.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug uprobes/10595] uprobe probes causes selinux failures X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00713.txt.bz2 ------- Additional Comments From mjw at redhat dot com 2009-09-14 19:51 ------- (In reply to comment #14) > (In reply to comment #13) > > To prevent leaks, the filp created needs to be saved away, and later fput()'d > > at deallocation time. > > when the vma gets deallocated the filp will be fput also, see mm/mmap.c > remove_vma(). On irc fche pointed out that fput() just cancels the get_file() in mm/mmap.c (mmap_region). So we probably should fput it immediately after calling do_mmap_pgoff(). Hint: Examine the sequence and f_counts with some well placed stap kernel.function* trace probes. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10595 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.