public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "mjw at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/10595] uprobe probes causes selinux failures
Date: Thu, 17 Sep 2009 10:27:00 -0000	[thread overview]
Message-ID: <20090917102712.4897.qmail@sourceware.org> (raw)
In-Reply-To: <20090903122458.10595.mjw@redhat.com>


------- Additional Comments From mjw at redhat dot com  2009-09-17 10:27 -------
For now I only fixed this for uprobe2 and only for kernels 2.6.28+

commit a82ac1f413712a375d5e14ef7641ce0abf7a6543
Author: Mark Wielaard <mjw@redhat.com>
Date:   Thu Sep 17 12:20:07 2009 +0200

    PR10595 Work around uprobe2 causing selinux failures for kernel 2.6.28+.
    
    We allocate a "fake" unlinked shmem file because anonymous
    memory might not be granted execute permission when the selinux
    security hooks have their way. Only do this for 2.6.28 or higher
    since shmem_file_setup() isn't exported before that.
    
    * runtime/uprobes2/uprobes.c (uprobe_setup_ssol_vma): Use shmem_file_setup
      to setup the ssol vma area when using 2.6.28+.

This incorporates the suggestions from Jim and Frank above.

For upstream the version checks are obviously not necessary, but I ran out of
time doing those plus the testing.

I'll keep the bug open till I also submitted a version for the upstream uprobes
code. And till we decided whether it makes sense to find some other workaround
for < 2.6.28 kernels and/or uprobes1 (I don't think we should really care, such
old systems often have much more relaxed selinux policies).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10595

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

  parent reply	other threads:[~2009-09-17 10:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 12:25 [Bug uprobes/10595] New: uprobe return " mjw at redhat dot com
2009-09-03 14:18 ` [Bug uprobes/10595] " mjw at redhat dot com
2009-09-03 16:25 ` [Bug uprobes/10595] uprobe " mjw at redhat dot com
2009-09-03 17:44 ` jkenisto at us dot ibm dot com
2009-09-03 20:13 ` mjw at redhat dot com
2009-09-04 11:09 ` mjw at redhat dot com
2009-09-04 11:58 ` srikar at linux dot vnet dot ibm dot com
2009-09-04 17:11 ` jkenisto at us dot ibm dot com
2009-09-04 17:25 ` mjw at redhat dot com
2009-09-04 18:08 ` jkenisto at us dot ibm dot com
2009-09-07 11:38 ` mjw at redhat dot com
2009-09-08 12:26 ` srikar at linux dot vnet dot ibm dot com
2009-09-10 15:50 ` fche at redhat dot com
2009-09-14 18:51 ` fche at redhat dot com
2009-09-14 19:27 ` mjw at redhat dot com
2009-09-14 19:51 ` mjw at redhat dot com
2009-09-17 10:27 ` mjw at redhat dot com [this message]
2009-09-17 13:14 ` mjw at redhat dot com
2009-09-17 15:53 ` fche at redhat dot com
2009-09-18 15:08 ` mjw at redhat dot com
2009-12-14 14:19 ` mjw at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090917102712.4897.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).