[Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message.

[Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message.

[srinivasa at in dot ibm dot com]

Environment: elfutils-0.137, systemtap-20080913 snapshot.

I was developing testcases for uprobes, But any attempt to probe all statements
of a file fails by giving error message.

Consider a .c file /root
=================================
 1 #include<stdlib.h>
  2 int main()
  3 {
  4 int i=0;
  5 i = i + 5;
  6 printf("i value is %d \n", i);
  7 return 0;
  8 }
================================

Execution of below script fails by throwing error message.
./stap -vvvvvv -e 'probe process("/root/a.out").statement("main@/root/ex.c:*") {
printf("%s\n",pp())}'  
================================
SystemTap translator/driver (version 0.7.1/0.131 non-git sources)
Copyright (C) 2005-2008 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
Session arch: x86_64 release: 2.6.18-113.el5
Created temporary directory "/tmp/stap27MWVb"
Searched '/usr/local/share/systemtap/tapset/x86_64/*.stp', found 2
Searched '/usr/local/share/systemtap/tapset/*.stp', found 43
Pass 1: parsed user script and 45 library script(s) in 230usr/10sys/250real ms.
parsed 'main@/root/ex.c:*' -> func 'main', file '/root/ex.c', line 0x7fffd3382624
pattern '/root/a.out' matches module '/root/a.out'
focused on module '/root/a.out = [0x400000-0x600898, bias 0x0] file /root/a.out
ELF machine x86_64 (code 62)
focused on module '/root/a.out'
selected source file '/root/ex.c'
function cache /root/a.out:ex.c size 1
function cache /root/a.out:ex.c hit main
pattern 'main' matches function 'main'
selected function main
function DIE lands on srcfile
probe main@/root/ex.c:3 process=/root/a.out reloc=.absolute section=.text
pc=0x400498
function DIE lands on srcfile
probe main@/root/ex.c:4 process=/root/a.out reloc=.absolute section=.text
pc=0x4004a0
function DIE lands on srcfile
probe main@/root/ex.c:5 process=/root/a.out reloc=.absolute section=.text
pc=0x4004a7
function DIE lands on srcfile
probe main@/root/ex.c:6 process=/root/a.out reloc=.absolute section=.text
pc=0x4004ab
function DIE lands on srcfile
probe main@/root/ex.c:7 process=/root/a.out reloc=.absolute section=.text
pc=0x4004bd
function DIE lands on srcfile
probe main@/root/ex.c:8 process=/root/a.out reloc=.absolute section=.text
pc=0x4004c2
semantic error: libdw failure (dwarf_getsrc_file): no matching address range
dwarf_builder releasing user dwflpp /root/a.out
Pass 2: analyzed script: 6 probe(s), 29 function(s), 0 embed(s), 0 global(s) in
0usr/0sys/7real ms.
Pass 2: analysis failed.  Try again with more '-v' (verbose) options.
Running rm -rf /tmp/stap27MWVb
========================================

-- 
           Summary: process("a").statement("main@/root/a.c:*")  fails by
                    giving error message.
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: srinivasa at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-09-19 11:16 -------
Passing invalid line number(line number greater than last line of the file) to
dwarf_getsrc_file() is causing the problem.
=================================================================
 void iterate_over_srcfile_lines (char const * srcfile,
                                   int lines[2],
                                   bool need_single_match,
                                   enum line_t line_type,
                                   void (* callback) (const dwarf_line_t& line,
                                                      void * arg),
                                   void *data)
  {
    Dwarf_Line **srcsp = NULL;
    size_t nsrcs = 0;
    dwarf_query * q = static_cast<dwarf_query *>(data);
    int lineno = lines[0];
    auto_free_ref<Dwarf_Line**> free_srcsp(srcsp);

    get_module_dwarf();
    ...........................
    ...........................
    dwarf_assert ("dwarf_getsrc_file",
                      dwarf_getsrc_file (module_dwarf,
                                         srcfile, l, 0,
                                         &srcsp, &nsrcs));
        if (line_type == WILDCARD || line_type == RANGE)
          {
            Dwarf_Addr line_addr;
            dwarf_lineno (srcsp [0], &lineno);
            line_probed = lines_probed.insert(lineno);
            if (lineno != l || line_probed.second == false || nsrcs > 1)
              continue;
            dwarf_lineaddr (srcsp [0], &line_addr);
            if (dwarf_haspc (function, line_addr) != 1)
              break;
          }
=======================================================

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2008-12-15 09:02 -------
Created an attachment (id=3108)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3108&action=view)
patch for 6905

Let stap tolerate invalid line and break matching for wildcard and range case.
Meanwhile make stap smart to check line range. 

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-12-16 17:51 -------
The patch looks plausible, but please also submit a test case and results.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2008-12-17 02:49 -------
Same C file as above described.
$ gcc -g -o ex ex.c
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") {}'  
# probes
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:3") /*
pc=.absolute+0x4004cc */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:4") /*
pc=.absolute+0x4004d4 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:5") /*
pc=.absolute+0x4004db */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:6") /*
pc=.absolute+0x4004df */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:7") /*
pc=.absolute+0x4004f1 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:8") /*
pc=.absolute+0x4004f6 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */

Invalid Range:
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c: 1-2") {}'  
semantic error: Starting line number for /home/wjhuang/ex.c : 3
semantic error: no match while resolving probe point
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-2")
semantic error: no probes found
Pass 2: analysis failed.  Try again with another '--vp 01' option.

Excessive Range:
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") {}'  
# probes
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:3") /*
pc=.absolute+0x4004cc */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:4") /*
pc=.absolute+0x4004d4 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:5") /*
pc=.absolute+0x4004db */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:6") /*
pc=.absolute+0x4004df */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:7") /*
pc=.absolute+0x4004f1 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:8") /*
pc=.absolute+0x4004f6 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-12-18 18:15 -------
Having looked into this area a bit more, it seems like we have
some major cleanup to do.  See also bug #5076, bug #2475, and
even bug #6864.  I'll try to reorganize this area of the code,
which should make your patch moot.  Can you hold on a few weeks?


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2008-12-19 02:04 -------
np. Like to rebase on new organized code if needed.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-07-27 02:38 -------
Created an attachment (id=4087)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4087&action=view)
patch and testcase

The related code has been re-organized, but the problem still exists. The patch

has been rebased and a simple test case is provided.

Example:
$ stap -p2 -e 'probe
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*")
{print("ok")}'
# probes
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:4") /*
pc=.absolute+0x80483c4 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:5") /*
pc=.absolute+0x80483cd */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:6") /*
pc=.absolute+0x80483d5 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:7") /*
pc=.absolute+0x80483da */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:8") /*
pc=.absolute+0x80483ee */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:9") /*
pc=.absolute+0x80483f3 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #3108 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-07-28 02:07 -------
commit	1123a74ab28d4ae9f2db0d704ce3981064ed9591

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-09-21 18:31 -------
committed


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=6905

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.