[Bug runtime/10724] New: stap should not retry if there is a permissions error

[Bug runtime/10724] New: stap should not retry if there is a permissions error

[chwang at redhat dot com]

Currently, stap command attempts to delete modules and retry when it encounters
an error. This should not happen when the error encountered is caused by a lack
of permission [since relaunching won't change the permissions].

-- 
           Summary: stap should not retry if there is a permissions error
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: chwang at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10724

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10724] stap should not retry if there is a permissions error

[chwang at redhat dot com]

------- Additional Comments From chwang at redhat dot com  2009-10-02 18:05 -------
(In reply to comment #0)
> Currently, stap command attempts to delete modules and retry when it encounters
> an error. This should not happen when the error encountered is caused by a lack
> of permission [since relaunching won't change the permissions].

Reproduction notes:
1. Log in as a user without stapdev privileges
2. Attempt to run stap -e 'probe begin {printf("Hello World!")}'
3. Output will look like: 
ERROR: You are trying to run stap as a normal user.
You should either be root, or be part of either group "stapdev" or group "stapusr".
Alternatively, your module must be compiled using the --unprivileged option and
signed by a trusted signer.
For more information, please consult the "SAFETY AND SECURITY" section of the
"stap(1)" manpage
Retrying, after attempted removal of module <blah> (rc -1)
ERROR: You are trying to run stap as a normal user.
You should either be root, or be part of either group "stapdev" or group "stapusr".
Alternatively, your module must be compiled using the --unprivileged option and
signed by a trusted signer.
For more information, please consult the "SAFETY AND SECURITY" section of the
"stap(1)" manpage

Note the repetition of the error message caused by an attempted relaunch.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10724

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10724] stap should not retry if there is a permissions error

[chwang at redhat dot com]

------- Additional Comments From chwang at redhat dot com  2009-10-02 18:46 -------
Created an attachment (id=4244)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4244&action=view)
Change check_permission to assert_permission in staprun_funcs

Pending advice from Frank and Dave, changed check_permission to return void and
renamed it to assert_permission. assert_permission simply returns if
permissions are okay, and calls exit(-1) if there are any permissions errors.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10724

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.