[Bug runtime/10821] New: unwind_frame has an oversized frame

[Bug runtime/10821] New: unwind_frame has an oversized frame

[jistone at redhat dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

On 2.6.30.8-64.fc11.x86_64:

$ stap -p4 ../testsuite/buildok/context_test.stp
cc1: warnings being treated as errors
In file included from /usr/local/share/systemtap/runtime/stack.c:26,
                 from
/tmp/stapcvUvUt/stap_7aca071c79275fba5c92f0959120a18d_8494.c:52:
/usr/local/share/systemtap/runtime/unwind.c: In function ‘unwind_frame’:
/usr/local/share/systemtap/runtime/unwind.c:862: error: the frame size of 544
bytes is larger than 512 bytes
make[1]: *** [/tmp/stapcvUvUt/stap_7aca071c79275fba5c92f0959120a18d_8494.o] Error 1
make: *** [_module_/tmp/stapcvUvUt] Error 2
Pass 4: compilation failed.  Try again with another '--vp 0001' option.

-- 
           Summary: unwind_frame has an oversized frame
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: jistone at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10821] unwind_frame has an oversized frame

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-10-21 16:10 -------
Commit 1d2cd5ff relaxes the -Wframe-larger-than check as a temporary workaround...

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10821] unwind_frame has an oversized frame

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-10-28 11:57 -------
This comes from the unwind_frame() local struct unwind_state state;
Which is defined in unwind/unwind.h as:

struct unwind_state {
        uleb128_t loc, org;
        const u8 *cieStart, *cieEnd;
        uleb128_t codeAlign;
        sleb128_t dataAlign;
        struct cfa {
                uleb128_t reg, offs;
        } cfa;
        struct unwind_item regs[ARRAY_SIZE(reg_info)];
        unsigned stackDepth:8;
        unsigned version:8;
        const u8 *label;
        const u8 *stack[STP_MAX_STACK_DEPTH];
};

So with struct unwind_item regs[ARRAY_SIZE(reg_info)]; that is pretty big...

It would be nice if we could allocate this per thread/cpu.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10821] unwind_frame has an oversized frame

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-10-28 12:40 -------
One suggestion would be to make unwind_state part of the probe context data
which is staticly allocated. Then we could pass the state from the
[u]context-unwind.stp script-level for use with the unwinder.

It does add a few hundred bytes even for probes points that don't do unwinding,
and currently only x86 uses the dwarf unwinder.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/10821] unwind_frame has an oversized frame

[wcohen at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10821

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/10821] unwind_frame has an oversized frame

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10821

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjw at redhat dot com

--- Comment #4 from Mark Wielaard <mjw at redhat dot com> 2010-11-04 19:42:43 UTC ---
(In reply to comment #3)
> It does add a few hundred bytes even for probes points that don't do unwinding,
> and currently only x86 uses the dwarf unwinder.

We discussed on irc, and if we unwind_state in the context data with
 #if defined(STP_USE_DWARF_UNWINDER) && defined(STP_NEED_UNWIND_DATA)
then it should only be included when really needed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/10821] unwind_frame has an oversized frame

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10821

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Josh Stone <jistone at redhat dot com> 2010-11-06 01:26:47 UTC ---
commit 01a2eba

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.