public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/10822] New: procfs file created too late
Date: Wed, 21 Oct 2009 21:10:00 -0000	[thread overview]
Message-ID: <20091021211006.10822.dsmith@redhat.com> (raw)

I've investigated some testsuite/systemtap.base/onoffprobe.exp failures I was
seeing.  After seeing the output from the begin probe, the testcase immediately
tries to write to the procfs file created by the script.  This kept failing.

In looking at the translator-created C file, I see this:

====
   for (i=0; i<2; i++) {                                                       
      struct stap_be_probe* stp = & stap_be_probes [i];                         
      if (stp->type == 1)                                                       
        enter_be_probe (stp);                                                   
    }                                                                           
    for (i=0; i<2; i++) {                                                       
      struct stap_be_probe* stp = & stap_be_probes [i];                         
      if (stp->type == 2)                                                       
        enter_be_probe (stp);                                                   
    }                                                                           
    goto out;                                                                   
  }                                                                             
  for (i = 0; i < 1; i++) {                                                     
    struct stap_procfs_probe *spp = &stap_procfs_probes[i];                     
    if (spp->read_pp)                                                           
      probe_point = spp->read_pp;                                               
    else                                                                        
      probe_point = spp->write_pp;                                              
    rc = _stp_create_procfs(spp->path, i);                                      
====

From the above, it appears that the begin probes are run, then the procfs file
is created.  I don't believe this is correct - begin probes should be run after
all the other probes types module init code has been run.

-- 
           Summary: procfs file created too late
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: dsmith at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10822

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

             reply	other threads:[~2009-10-21 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 21:10 dsmith at redhat dot com [this message]
2009-10-21 22:23 ` [Bug translator/10822] " jistone at redhat dot com
2009-10-22  0:29 ` fche at redhat dot com
2009-10-22 13:12 ` dsmith at redhat dot com
2009-10-22 13:26 ` dsmith at redhat dot com
2009-10-22 14:05 ` dsmith at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091021211006.10822.dsmith@redhat.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).