public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "srikar at linux dot vnet dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/10836] uprobes-provided pt_regs* are unreliable
Date: Tue, 27 Oct 2009 11:44:00 -0000	[thread overview]
Message-ID: <20091027114431.7861.qmail@sourceware.org> (raw)
In-Reply-To: <20091023162529.10836.fche@redhat.com>


------- Additional Comments From srikar at linux dot vnet dot ibm dot com  2009-10-27 11:44 -------
I am not sure if I understand the problem completely.

> Several registers appearing in a utrace-oriented pt_regs do not accurately
> represent the state of the user-space task. 

Is this concern about instruction pointer pointing past the breakpoint?
or do we have additional concerns? If yes do we have specific registers in mind?
                                        
uprobes passes the pt_regs it gets from utrace's report_signal callback as is to
the handler.

> As per bug #10601, this breaks
> some dwarf-based $context variables.

This bug refers to two other bugs which point to problems in user space markers.
 So is this problem only seen on user space markers? or can we see this problem
on plain uprobes probe points too.

> It seems to me that either uprobes should not pass pt_regs at all to its
> callbacks, or else populate it with synthetic (but accurate) values pulled
> out of utrace regset calls.  (The latter would be slower and require per-arch
> code, but would make it more convenient for the clients.  The former would
> be faster, and still require per-arch code at the client, but would be less
> convenient.)

Is there any reason why this synthesis should be done at the uprobes end and not
at the client end?  Do you see all uprobe clients facing this problem?
If its a problem faced by all uprobe clients, then is it worth checking if
utrace should send the synthesized pt_regs as a parameter to report_signal.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roland at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10836

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

  reply	other threads:[~2009-10-27 11:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23 16:25 [Bug uprobes/10836] New: " fche at redhat dot com
2009-10-27 11:44 ` srikar at linux dot vnet dot ibm dot com [this message]
2009-10-27 11:45 ` [Bug uprobes/10836] " srikar at linux dot vnet dot ibm dot com
2009-10-27 12:27 ` fche at redhat dot com
2009-10-27 18:40 ` roland at gnu dot org
2009-10-27 19:17 ` fche at redhat dot com
2009-10-28 12:29 ` mjw at redhat dot com
2009-10-28 16:53 ` jkenisto at us dot ibm dot com
2009-10-28 16:56 ` fche at redhat dot com
2009-10-28 16:59 ` fche at redhat dot com
2009-10-28 18:22 ` roland at gnu dot org
2009-10-29  6:20 ` ananth at in dot ibm dot com
2009-10-29 14:29 ` fche at redhat dot com
2009-11-05 13:57 ` fche at redhat dot com
2009-11-30 20:36 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027114431.7861.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).