From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16869 invoked by alias); 28 Oct 2009 16:53:24 -0000 Received: (qmail 16832 invoked by uid 48); 28 Oct 2009 16:53:13 -0000 Date: Wed, 28 Oct 2009 16:53:00 -0000 Message-ID: <20091028165313.16831.qmail@sourceware.org> From: "jkenisto at us dot ibm dot com" To: systemtap@sources.redhat.com In-Reply-To: <20091023162529.10836.fche@redhat.com> References: <20091023162529.10836.fche@redhat.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug uprobes/10836] uprobes-provided pt_regs* are unreliable X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00334.txt.bz2 ------- Additional Comments From jkenisto at us dot ibm dot com 2009-10-28 16:53 ------- (In reply to comment #3) > "synthesized pt_regs" is a loony concept considered only by systemtap. > It has no place in the general utrace world. user_regset is there, it's what > should be used. The only reason pt_regs is passed into some callbacks is > because the pointer is handy and in some circumstances a few of its fields might > be sufficiently useful for particular code that knows exactly what it is looking > at. General-case code can use the asm/syscall.h macros on it, for example. For > any generalized register access, user_regset is the only right thing to use. Previous advice (as I understood it) from Roland during the uprobes 2 port (~August '08) was to continue using the pt_regs pointer passed to uprobe_report_signal(). So before Srikar adds a lot of user_regset code to uprobes, it'd be nice clarify what Roland means by "any generalized register access." For example, at least some architectures' user_regset code boils down to references to the pt_regs pointer provided by task_pt_regs(). For the registers that SystemTap actually references, would the pointer provided by task_pt_regs() be sufficient? -- http://sourceware.org/bugzilla/show_bug.cgi?id=10836 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.