public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Wenji Huang" <wenji.huang@oracle.com>
To: "systemtap@sourceware.org" <systemtap@sourceware.org>
Subject: RE: [RFC PATCH] Fix segmentation fault of listing kprocess.create
Date: Thu, 05 Nov 2009 07:36:00 -0000	[thread overview]
Message-ID: <20091105153851046.00000002852@ETSD-Ora-lap2> (raw)
In-Reply-To: <20091105150217031.00000001204@ETSD-Ora-lap2>

Hi,

Sorry for a little annoying thread. ^-^
> Please ignore the previous patch, the root cause is the 
> following section
> tapsets.cxx: dwarf_derived_probe::saveargs
> 
>          /* trick from visit_target_symbol_context */
>          target_symbol *tsym = new target_symbol;
>          token *t = new token;
>          tsym->tok = t;
>          tsym->base_name = "$";
>          tsym->base_name += arg_name;
> 
> The empty token is created, I will fix it soon. 
> Also any suggestion is welcome!
> 
Take a deep look. Seems we will try to access the variables in
return probe. It's fully supported or not? Guess not.

If not, the function should return early once has_return is true.
If yes, we will hypothesize accessing the argument. And the
source_loc of t has to be q.base_loc since no real one.

Regards,
Wenji

  reply	other threads:[~2009-11-05  7:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  5:03 Wenji Huang
2009-11-05  7:00 ` Wenji Huang
2009-11-05  7:36   ` Wenji Huang [this message]
2009-11-05 14:12     ` Frank Ch. Eigler
2009-11-06  1:08       ` Wenji Huang
2009-11-06 11:19         ` Frank Ch. Eigler
2009-11-07  0:14     ` Josh Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091105153851046.00000002852@ETSD-Ora-lap2 \
    --to=wenji.huang@oracle.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).