From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1089 invoked by alias); 6 Nov 2009 11:19:55 -0000 Received: (qmail 1057 invoked by uid 22791); 6 Nov 2009 11:19:54 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Nov 2009 11:19:47 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA6BJeZF021172; Fri, 6 Nov 2009 06:19:40 -0500 Received: from fche.csb (vpn-227-44.phx2.redhat.com [10.3.227.44]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA6BJerr027268; Fri, 6 Nov 2009 06:19:40 -0500 Received: by fche.csb (Postfix, from userid 2569) id E7BBE58122; Fri, 6 Nov 2009 06:19:39 -0500 (EST) Date: Fri, 06 Nov 2009 11:19:00 -0000 From: "Frank Ch. Eigler" To: Wenji Huang Cc: "systemtap@sourceware.org" Subject: Re: [RFC PATCH] Fix segmentation fault of listing kprocess.create Message-ID: <20091106111939.GA7039@redhat.com> References: <20091105150217031.00000001204@ETSD-Ora-lap2> <20091105153851046.00000002852@ETSD-Ora-lap2> <4AF37691.6000601@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF37691.6000601@oracle.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00450.txt.bz2 Hi - On Fri, Nov 06, 2009 at 09:06:25AM +0800, Wenji Huang wrote: > [...] > The empty token is from my patch for 10820, sorry for the > error. [...] No problem. > diff --git a/tapsets.cxx b/tapsets.cxx > index d2c3334..17e315e 100644 > --- a/tapsets.cxx > +++ b/tapsets.cxx > @@ -2928,6 +2928,14 @@ dwarf_derived_probe::saveargs(dwarf_query& q, > Dwarf_Die* scope_die, dwarf_var_ex > /* trick from visit_target_symbol_context */ > target_symbol *tsym = new target_symbol; > token *t = new token; > + /* We hypothesize accessing the argument > + * The source_loc will be base_loc since no real one */ > + t->content = "$"; > + t->content += arg_name; > + t->type = tok_identifier; > + t->location.file = q.base_loc->tok->location.file; > + t->location.column = q.base_loc->tok->location.column; > + t->location.line = q.base_loc->tok->location.line; > tsym->tok = t; You shouldn't need to synthesize this either really. Just copy the pointer from q.base_loc->tok, if we don't have a vardecl or expression handy. - FChE