From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-14270-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 14900 invoked by alias); 13 Nov 2009 23:09:35 -0000
Received: (qmail 14891 invoked by uid 22791); 13 Nov 2009 23:09:34 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp1.linux-foundation.org (HELO smtp1.linux-foundation.org) (140.211.169.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 23:09:30 +0000
Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) 	by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id nADN95C5024816 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Fri, 13 Nov 2009 15:09:06 -0800
Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) 	by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id nADN94hW002511; 	Fri, 13 Nov 2009 15:09:04 -0800
Date: Fri, 13 Nov 2009 23:09:00 -0000
From: Andrew Morton <akpm@linux-foundation.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>,         DLE  <dle-develop@lists.sourceforge.net>,         Hidehiro Kawai  <hidehiro.kawai.ez@hitachi.com>,         Oleg Nesterov <oleg@redhat.com>, Roland  McGrath <roland@redhat.com>
Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag  consistency
Message-Id: <20091113150904.56c15910.akpm@linux-foundation.org>
In-Reply-To: <20091113225226.15079.90813.stgit@harusame>
References: <20091113225226.15079.90813.stgit@harusame>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-MIMEDefang-Filter: lf$Revision: 1.188 $
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2009-q4/txt/msg00511.txt.bz2

On Fri, 13 Nov 2009 17:52:27 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Pass mm->flags to binfmt core_dump for bitflag consistency.
> Since mm->flags bit flags is not protected by locks, it will be
> changed while dumping core. This patch copies mm->flags to a
> mm_flags local variable at the beginning of do_coredump() and
> use it while dumping. mm_flags also includes dump_filter which
> filters elf sections from core file in elf_core_dump().
> So, this patch also passes mm_flags to each binfmt->core_dump().

I can kind-of guess the answer, but it would be much more reliable if
we were to hear this from yourself:

  Why did you write this patch?  What problem is being observed?