From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24414 invoked by alias); 13 Nov 2009 23:25:11 -0000 Received: (qmail 24405 invoked by uid 22791); 13 Nov 2009 23:25:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx3.mail.elte.hu (HELO mx3.mail.elte.hu) (157.181.1.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 23:25:07 +0000 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1N95Vk-0007vw-Hl from ; Sat, 14 Nov 2009 00:25:00 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id ED0233E22F7; Sat, 14 Nov 2009 00:24:56 +0100 (CET) Date: Fri, 13 Nov 2009 23:25:00 -0000 From: Ingo Molnar To: Andrew Morton Cc: Masami Hiramatsu , lkml , systemtap , DLE , Hidehiro Kawai , Oleg Nesterov , Roland McGrath Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency Message-ID: <20091113232457.GC21666@elte.hu> References: <20091113225226.15079.90813.stgit@harusame> <20091113150904.56c15910.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091113150904.56c15910.akpm@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00514.txt.bz2 * Andrew Morton wrote: > On Fri, 13 Nov 2009 17:52:27 -0500 > Masami Hiramatsu wrote: > > > Pass mm->flags to binfmt core_dump for bitflag consistency. > > Since mm->flags bit flags is not protected by locks, it will be > > changed while dumping core. This patch copies mm->flags to a > > mm_flags local variable at the beginning of do_coredump() and > > use it while dumping. mm_flags also includes dump_filter which > > filters elf sections from core file in elf_core_dump(). > > So, this patch also passes mm_flags to each binfmt->core_dump(). > > I can kind-of guess the answer, but it would be much more reliable if > we were to hear this from yourself: > > Why did you write this patch? What problem is being observed? i'm not Masami so i'm only guessing that while writing the tracepoint a race got noticed but that otherwise there's no big practical effect, 'just' a cleanliness problem fixed. Ingo