From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-14274-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 26807 invoked by alias); 13 Nov 2009 23:30:11 -0000
Received: (qmail 26797 invoked by uid 22791); 13 Nov 2009 23:30:09 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 23:30:02 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nADNU1bh020520 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <systemtap@sources.redhat.com>; Fri, 13 Nov 2009 18:30:01 -0500
Received: from gateway.sf.frob.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nADNU0J7002294; 	Fri, 13 Nov 2009 18:30:01 -0500
Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) 	by gateway.sf.frob.com (Postfix) with ESMTP 	id 2D3CE357B; Fri, 13 Nov 2009 15:30:00 -0800 (PST)
Received: by magilla.sf.frob.com (Postfix, from userid 5281) 	id EF2F9100E; Fri, 13 Nov 2009 15:29:59 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
X-Fcc: ~/Mail/linus
Cc: Masami Hiramatsu <mhiramat@redhat.com>,         lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>,         DLE <dle-develop@lists.sourceforge.net>,         Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,         Andrew Morton <akpm@linux-foundation.org>,         Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag  consistency
In-Reply-To: Ingo Molnar's message of  Saturday, 14 November 2009 00:23:07 +0100 <20091113232307.GB21666@elte.hu>
References: <20091113225226.15079.90813.stgit@harusame> 	<20091113231602.2DD2C100E@magilla.sf.frob.com> 	<20091113232307.GB21666@elte.hu>
Message-Id: <20091113232959.EF2F9100E@magilla.sf.frob.com>
Date: Fri, 13 Nov 2009 23:30:00 -0000
X-IsSubscribed: yes
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2009-q4/txt/msg00515.txt.bz2

> this would fix the (probably harmless) race too, but isnt the whole 
> approach taken by the patch more robust, i.e. to take a snapshot of 
> mm->flags value and pass it along coredump processing?

Yes, I think it is a fine thing to do.  I'm just being explicit about what
I think the (only) concrete issues are motivating a change.

> we should probably introduce a coredump parameter struct, and pass that 
> along:

Also sounds fine to me.


Thanks,
Roland