From: Masami Hiramatsu <mhiramat@redhat.com>
To: linux-next@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: lkml<linux-kernel@vger.kernel.org>,
systemtap<systemtap@sources.redhat.com>,
DLE<dle-develop@lists.sourceforge.net>,
Masami Hiramatsu <mhiramat@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@xenotime.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Jim Keniston <jkenisto@us.ibm.com>
Subject: [PATCH -next 3/3] x86: insn decoder test shows build warning
Date: Mon, 16 Nov 2009 23:07:00 -0000 [thread overview]
Message-ID: <20091116230631.5250.41579.stgit@harusame> (raw)
In-Reply-To: <20091116230611.5250.86656.stgit@harusame>
Since some instructions are not decoded correctly by objdump, it
may cause false positive error in insn decoder posttest. This
changes build error of insn decoder test to build warning.
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jim Keniston <jkenisto@us.ibm.com>
---
arch/x86/tools/test_get_len.c | 17 +++++++++++------
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/arch/x86/tools/test_get_len.c b/arch/x86/tools/test_get_len.c
index af75e07..d8214dc 100644
--- a/arch/x86/tools/test_get_len.c
+++ b/arch/x86/tools/test_get_len.c
@@ -114,6 +114,7 @@ int main(int argc, char **argv)
unsigned char insn_buf[16];
struct insn insn;
int insns = 0, c;
+ int warnings = 0;
parse_args(argc, argv);
@@ -151,18 +152,22 @@ int main(int argc, char **argv)
insn_init(&insn, insn_buf, x86_64);
insn_get_length(&insn);
if (insn.length != nb) {
- fprintf(stderr, "Error: %s found a difference at %s\n",
+ warnings++;
+ fprintf(stderr, "Warning: %s found difference at %s\n",
prog, sym);
- fprintf(stderr, "Error: %s", line);
- fprintf(stderr, "Error: objdump says %d bytes, but "
+ fprintf(stderr, "Warning: %s", line);
+ fprintf(stderr, "Warning: objdump says %d bytes, but "
"insn_get_length() says %d\n", nb,
insn.length);
if (verbose)
dump_insn(stderr, &insn);
- exit(2);
}
}
- fprintf(stderr, "Succeed: decoded and checked %d instructions\n",
- insns);
+ if (warnings)
+ fprintf(stderr, "Warning: decoded and checked %d"
+ " instructions with %d warnings\n", insns, warnings);
+ else
+ fprintf(stderr, "Succeed: decoded and checked %d"
+ " instructions\n", insns);
return 0;
}
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-11-16 23:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 23:07 [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) Masami Hiramatsu
2009-11-16 23:07 ` [PATCH -next 2/3] x86: Show symbol name if insn decoder test failed Masami Hiramatsu
2009-11-17 6:34 ` [tip:perf/probes] " tip-bot for Masami Hiramatsu
2009-11-16 23:07 ` [PATCH -next 1/3] x86: Add verbose option to insn decoder test Masami Hiramatsu
2009-11-17 6:34 ` [tip:perf/probes] " tip-bot for Masami Hiramatsu
2009-11-16 23:07 ` Masami Hiramatsu [this message]
2009-11-20 5:43 ` [tip:perf/core] x86: Instruction decoder test should generate build warning tip-bot for Masami Hiramatsu
2009-11-17 6:15 ` [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) Ingo Molnar
2009-11-17 6:54 ` Masami Hiramatsu
2009-11-18 4:45 ` H. Peter Anvin
2009-11-20 17:11 ` [PATCH -tip 0/2] x86 insn decoder test checking objdump version Masami Hiramatsu
2009-11-20 17:11 ` [PATCH -tip 1/2] [BUGFIX] x86: Fix insn decoder test typos Masami Hiramatsu
2009-11-20 17:11 ` [PATCH -tip 2/2] x86: insn decoder test checks objdump version Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116230631.5250.41579.stgit@harusame \
--to=mhiramat@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).