From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20116 invoked by alias); 17 Nov 2009 06:15:19 -0000 Received: (qmail 20076 invoked by uid 22791); 17 Nov 2009 06:15:18 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx3.mail.elte.hu (HELO mx3.mail.elte.hu) (157.181.1.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Nov 2009 06:14:14 +0000 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1NAHK8-0000LH-Kc from ; Tue, 17 Nov 2009 07:13:59 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id BC6E53E22F7; Tue, 17 Nov 2009 07:13:52 +0100 (CET) Date: Tue, 17 Nov 2009 06:15:00 -0000 From: Ingo Molnar To: Masami Hiramatsu Cc: linux-next@vger.kernel.org, Stephen Rothwell , Randy Dunlap , Jim Keniston , "H. Peter Anvin" , lkml , systemtap , DLE Subject: Re: [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) Message-ID: <20091117061352.GE30852@elte.hu> References: <20091116230611.5250.86656.stgit@harusame> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091116230611.5250.86656.stgit@harusame> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00548.txt.bz2 * Masami Hiramatsu wrote: > Here are the patches which update x86 instruction decoder build-time > test. As Stephen reported on linux-next, sometimes objdump decodes bad > instructions as normal. This will cause a false positive result on x86 > insn decoder test. This patches update the test as below; > > - Show more information with V=1 > - Show in which symbol the difference places. > - Just warning instead of build failure. yes, -tip testing was showing such build bugs too: Error: ffffffff8104aae3: c5 83 3d 49 80 ee lds 0xffffffffee80493d(%rbx),%eax Error: objdump says 6 bytes, but insn_get_length() says 3 (attr:0) it happens with older tools, such as binutils-2.17. Modern binutils (2.19) is fine. We dont want to remove the build error: it helped us fix a number of real bugs in the decoder - instead please try to create a make based workaround based on binutils, to not run the test with binutils older than 2.19 or so. Thanks, Ingo