From: "wenji dot huang at oracle dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug runtime/10189] STP_START gets lost in a warning flood
Date: Tue, 17 Nov 2009 08:06:00 -0000 [thread overview]
Message-ID: <20091117080601.2789.qmail@sourceware.org> (raw)
In-Reply-To: <20090522204505.10189.jistone@redhat.com>
------- Additional Comments From wenji dot huang at oracle dot com 2009-11-17 08:06 -------
Current stap will keep allocating buffer for _stp_warn in probe until
out of memory. As a result, _stp_ctl_send(STP_START,...) will be failed
due to exhausted memory. So the child process couldn't catch the signal
and remain waiting.
To increase STP_DEFAULT_BUFFERS is not good way, there always be a limit
for it. Maybe it's better to make _stp_warn utilize _stp_print instead of
_stp_ctl_write.
diff --git a/runtime/io.c b/runtime/io.c
index 0136aae..10b6c8a 100644
--- a/runtime/io.c
+++ b/runtime/io.c
@@ -55,7 +55,7 @@ static void _stp_vlog (enum code type, const char *func, int
line, const char *f
else if (type == ERROR) printk (KERN_ERR "%s", buf);
else printk (KERN_INFO "%s", buf);
#else
- if (type != DBUG)
+ if (type != DBUG && type != WARN)
_stp_ctl_write(STP_OOB_DATA, buf, start + num + 1);
else {
_stp_print(buf);
--
http://sourceware.org/bugzilla/show_bug.cgi?id=10189
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2009-11-17 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 20:45 [Bug runtime/10189] New: " jistone at redhat dot com
2009-11-16 9:47 ` [Bug runtime/10189] " wenji dot huang at oracle dot com
2009-11-17 8:06 ` wenji dot huang at oracle dot com [this message]
2009-11-17 17:31 ` fche at redhat dot com
[not found] <bug-10189-1110@http.sourceware.org/bugzilla/>
2010-11-08 20:02 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117080601.2789.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).