From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2836 invoked by alias); 17 Nov 2009 08:06:15 -0000 Received: (qmail 2790 invoked by uid 48); 17 Nov 2009 08:06:01 -0000 Date: Tue, 17 Nov 2009 08:06:00 -0000 Message-ID: <20091117080601.2789.qmail@sourceware.org> From: "wenji dot huang at oracle dot com" To: systemtap@sources.redhat.com In-Reply-To: <20090522204505.10189.jistone@redhat.com> References: <20090522204505.10189.jistone@redhat.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug runtime/10189] STP_START gets lost in a warning flood X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00552.txt.bz2 ------- Additional Comments From wenji dot huang at oracle dot com 2009-11-17 08:06 ------- Current stap will keep allocating buffer for _stp_warn in probe until out of memory. As a result, _stp_ctl_send(STP_START,...) will be failed due to exhausted memory. So the child process couldn't catch the signal and remain waiting. To increase STP_DEFAULT_BUFFERS is not good way, there always be a limit for it. Maybe it's better to make _stp_warn utilize _stp_print instead of _stp_ctl_write. diff --git a/runtime/io.c b/runtime/io.c index 0136aae..10b6c8a 100644 --- a/runtime/io.c +++ b/runtime/io.c @@ -55,7 +55,7 @@ static void _stp_vlog (enum code type, const char *func, int line, const char *f else if (type == ERROR) printk (KERN_ERR "%s", buf); else printk (KERN_INFO "%s", buf); #else - if (type != DBUG) + if (type != DBUG && type != WARN) _stp_ctl_write(STP_OOB_DATA, buf, start + num + 1); else { _stp_print(buf); -- http://sourceware.org/bugzilla/show_bug.cgi?id=10189 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.