From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29655 invoked by alias); 17 Nov 2009 23:52:30 -0000 Received: (qmail 29646 invoked by uid 22791); 17 Nov 2009 23:52:29 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Nov 2009 23:51:26 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAHNpILu001704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Nov 2009 18:51:19 -0500 Received: from dhcp-100-2-132.bos.redhat.com (dhcp-100-2-132.bos.redhat.com [10.16.2.132]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAHNojBa006404; Tue, 17 Nov 2009 18:51:01 -0500 From: Masami Hiramatsu Subject: [PATCH -tip 0/2] Fix mm->flags consistency issue in coredump To: Ingo Molnar , lkml Cc: Roland McGrath , Oleg Nesterov , Hidehiro Kawai , Andrew Morton , systemtap, DLE Date: Tue, 17 Nov 2009 23:52:00 -0000 Message-ID: <20091117235305.30900.43344.stgit@dhcp-100-2-132.bos.redhat.com> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00561.txt.bz2 Hi, These patches are for fixing coredump mm->flags consistency issue. --- 1787 if (mm->core_state || !get_dumpable(mm)) { <- (1) 1788 up_write(&mm->mmap_sem); 1789 put_cred(cred); 1790 goto fail; 1791 } 1792 [...] 1798 if (get_dumpable(mm) == 2) { /* Setuid core dump mode */ <-(2) 1799 flag = O_EXCL; /* Stop rewrite attacks */ 1800 cred->fsuid = 0; /* Dump root private */ 1801 } --- Since dumpable bits are not protected by lock, there is a chance to change these bits between (1) and (2). To solve this issue, this patch copies mm->flags to coredump_params.mm_flags at the beginning of do_coredump() and uses it instead of get_dumpable() while dumping core. This series also introduce coredump parameter structure for simplify bimfmt->core_dump interface. Thank you, --- Masami Hiramatsu (2): Pass mm->flags as a coredump parameter for consistency mm: Introduce coredump parameter structure fs/binfmt_aout.c | 13 ++++++----- fs/binfmt_elf.c | 50 +++++++++++++++++++---------------------- fs/binfmt_elf_fdpic.c | 38 ++++++++++++------------------- fs/binfmt_flat.c | 6 ++--- fs/binfmt_som.c | 2 +- fs/exec.c | 58 ++++++++++++++++++++++++++++++----------------- include/linux/binfmts.h | 11 ++++++++- 7 files changed, 97 insertions(+), 81 deletions(-) -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com