public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
	        Oleg Nesterov <oleg@redhat.com>,
	        systemtap <systemtap@sources.redhat.com>,
	        DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip 0/3] tracepoint: Add signal events
Date: Wed, 18 Nov 2009 03:08:00 -0000	[thread overview]
Message-ID: <20091118030706.EB93EA8C@magilla.sf.frob.com> (raw)
In-Reply-To: Masami Hiramatsu's message of  Tuesday, 17 November 2009 18:41:17 -0500 <20091117234117.30589.61311.stgit@dhcp-100-2-132.bos.redhat.com>

I would add the siginfo_t * argument to each of these tracepoints.

In 2/3 this comment:

+		/* Trace the actual delivered signals including SIG_IGN.*/

might be slightly misleading.  In most cases SIG_IGN signals won't make it
this far.  The same is true of SIG_DFL signals whose default action is to
ignore.  So one should be clear that trace_signal_deliver() is by no means
expected to get all SIG_IGN signals that are otherwise eligible for delivery.


Thanks,
Roland

  parent reply	other threads:[~2009-11-18  3:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 23:40 Masami Hiramatsu
2009-11-18  0:08 ` [PATCH -tip 1/3] tracepoint: Move signal sending tracepoint to events/signal.h Masami Hiramatsu
2009-11-18  0:11 ` [PATCH -tip 2/3] tracepoint: Add signal deliver event Masami Hiramatsu
2009-11-18  0:53 ` [PATCH -tip 3/3] tracepoint: Add signal loss events Masami Hiramatsu
2009-11-18  3:08 ` Roland McGrath [this message]
2009-11-18 16:33   ` [PATCH -tip 0/3] tracepoint: Add signal events Masami Hiramatsu
2009-11-18 21:19     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118030706.EB93EA8C@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).