From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12531 invoked by alias); 18 Nov 2009 21:19:39 -0000 Received: (qmail 12521 invoked by uid 22791); 18 Nov 2009 21:19:39 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Nov 2009 21:18:32 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAILIV6L027133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Nov 2009 16:18:31 -0500 Received: from gateway.sf.frob.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAILIUA4014904; Wed, 18 Nov 2009 16:18:30 -0500 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 81898357B; Wed, 18 Nov 2009 13:18:29 -0800 (PST) Received: by magilla.sf.frob.com (Postfix, from userid 5281) id 4A2471A8F; Wed, 18 Nov 2009 13:18:29 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Masami Hiramatsu X-Fcc: ~/Mail/linus Cc: Ingo Molnar , lkml , Oleg Nesterov , systemtap , DLE Subject: Re: [PATCH -tip 0/3] tracepoint: Add signal events In-Reply-To: Masami Hiramatsu's message of Wednesday, 18 November 2009 11:32:34 -0500 <4B0421A2.1080400@redhat.com> References: <20091117234117.30589.61311.stgit@dhcp-100-2-132.bos.redhat.com> <20091118030706.EB93EA8C@magilla.sf.frob.com> <4B0421A2.1080400@redhat.com> Message-Id: <20091118211829.4A2471A8F@magilla.sf.frob.com> Date: Wed, 18 Nov 2009 21:19:00 -0000 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00590.txt.bz2 > Roland McGrath wrote: > > I would add the siginfo_t * argument to each of these tracepoints. > > I see. Is it OK to record only si_errno and si_code? because si_signo > might be as same as sig. Yes, si_signo will match sig. Which siginfo_t fields are interesting to record can vary by signal (i.e. by si_code). si_code and si_errno are certainly the first things that come to mind as most useful. For SI_TIMER, si_tid, si_overrun, and si_sigval are interesting. For others, si_pid and si_uid are interesting. Thanks, Roland