From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-14438-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 12431 invoked by alias); 24 Nov 2009 20:20:11 -0000
Received: (qmail 12423 invoked by uid 22791); 24 Nov 2009 20:20:11 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.145)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Nov 2009 20:20:06 +0000
Received: by ey-out-1920.google.com with SMTP id 26so1831569eyw.24         for <systemtap@sources.redhat.com>; Tue, 24 Nov 2009 12:20:03 -0800 (PST)
Received: by 10.213.27.8 with SMTP id g8mr5637939ebc.58.1259094003603;         Tue, 24 Nov 2009 12:20:03 -0800 (PST)
Received: from nowhere (ADijon-552-1-123-3.w92-148.abo.wanadoo.fr [92.148.186.3])         by mx.google.com with ESMTPS id 13sm184024ewy.13.2009.11.24.12.19.59         (version=SSLv3 cipher=RC4-MD5);         Tue, 24 Nov 2009 12:20:01 -0800 (PST)
Received: by nowhere (nbSMTP-1.00) for uid 1000 	(using TLSv1/SSLv3 with cipher RC4-MD5 (128/128 bits)) 	fweisbec@gmail.com; Tue, 24 Nov 2009 21:20:02 +0100 (CET)
Date: Tue, 24 Nov 2009 20:20:00 -0000
From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>, Ingo Molnar <mingo@elte.hu>, 	Ananth N Mavinakayanahalli <ananth@in.ibm.com>, 	lkml <linux-kernel@vger.kernel.org>, 	systemtap <systemtap@sources.redhat.com>, 	DLE <dle-develop@lists.sourceforge.net>, 	Jim Keniston <jkenisto@us.ibm.com>, 	Srikar Dronamraju <srikar@linux.vnet.ibm.com>, 	Christoph Hellwig <hch@infradead.org>, 	Steven Rostedt <rostedt@goodmis.org>, 	"H. Peter Anvin" <hpa@zytor.com>, 	Anders Kaseorg <andersk@ksplice.com>, 	Tim Abbott <tabbott@ksplice.com>, Andi Kleen <andi@firstfloor.org>, 	Jason Baron <jbaron@redhat.com>, 	Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: [PATCH -tip v5 06/10] kprobes/x86: Cleanup save/restore 	registers
Message-ID: <20091124201957.GD5071@nowhere>
References: <20091123232115.22071.71558.stgit@dhcp-100-2-132.bos.redhat.com> <20091123232204.22071.60562.stgit@dhcp-100-2-132.bos.redhat.com> <20091124025115.GB6752@nowhere> <y0mtywkx76f.fsf@fche.csb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <y0mtywkx76f.fsf@fche.csb>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2009-q4/txt/msg00679.txt.bz2

On Tue, Nov 24, 2009 at 10:40:24AM -0500, Frank Ch. Eigler wrote:
> Frederic Weisbecker <fweisbec@gmail.com> writes:
> 
> > [...]
> >> +#define SAVE_REGS_STRING		\
> >> +#define RESTORE_REGS_STRING		\
> >
> > BTW, do you really need to push/pop every registers
> > before/after calling a probe handler?
> 
> It's part of the definition of a kprobe, that a populated
> pt_regs* value is passed.  Clients can rely on that in order
> to access registers etc.
> 
> - FChE

Yeah I made a confusion. Sorry.