From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3365 invoked by alias); 24 Nov 2009 21:28:08 -0000 Received: (qmail 3356 invoked by uid 22791); 24 Nov 2009 21:28:08 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Nov 2009 21:28:03 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAOLS11s021846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Nov 2009 16:28:01 -0500 Received: from tranklukator.englab.brq.redhat.com (tranklukator.englab.brq.redhat.com [10.34.32.241]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id nAOLRxnc004791; Tue, 24 Nov 2009 16:28:00 -0500 Received: by tranklukator.englab.brq.redhat.com (nbSMTP-1.00) for uid 500 onestero@redhat.com; Tue, 24 Nov 2009 22:22:50 +0100 (CET) Date: Tue, 24 Nov 2009 21:28:00 -0000 From: Oleg Nesterov To: Ingo Molnar Cc: Masami Hiramatsu , lkml , Roland McGrath , Jason Baron , systemtap , DLE Subject: Re: [PATCH -tip v3 0/3] tracepoint: Add signal events Message-ID: <20091124212247.GA11773@redhat.com> References: <20091120213108.14708.97871.stgit@dhcp-100-2-132.bos.redhat.com> <20091123175740.GA15594@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091123175740.GA15594@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00686.txt.bz2 On 11/23, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Hi, > > > > These patches add signal related tracepoints including > > signal generation, delivery, and loss. First patch also > > moves signal-sending tracepoint from events/sched.h to > > events/signal.h. > > > > Changes in v3 > > - Add Docbook style comments > > > > Changes in v2 > > - Add siginfo arguments > > > > Thank you, > > > > --- > > > > Masami Hiramatsu (3): > > tracepoint: Add signal loss events > > tracepoint: Add signal deliver event > > tracepoint: Move signal sending tracepoint to events/signal.h > > > > > > Documentation/DocBook/tracepoint.tmpl | 5 + > > include/trace/events/sched.h | 25 ----- > > include/trace/events/signal.h | 173 +++++++++++++++++++++++++++++++++ > > kernel/signal.c | 27 ++++- > > 4 files changed, 198 insertions(+), 32 deletions(-) > > create mode 100644 include/trace/events/signal.h > > Would be nice to have Roland's and Oleg's Acked-by tags in the patches - > to show that this is a representative and useful looking set of signal > events. Sorry, I can't really comment these patches. I mean, I do not know which info is useful and which is not. For example, I am a bit surprized we report trace_signal_lose_info() but please do not consider this as if I think we shouldn't. Just I do not know. OTOH, we do not report if __send_signal() fails just because the legacy signal is already queued. We do not report who sends the signal, we do not report if it was private or shared. zap_process, complete_signal can "send" SIGKILL via sigaddset, this won't be noticed. But again, it is not that I think this should be reported. In short: I think any info may be useful, and these patches can help. But I do not understand what exactly should be reported to userspace. Oleg.