From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Jim Keniston <jkenisto@us.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Jason Baron <jbaron@redhat.com>,
"K.Prasad" <prasad@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip 0/9] perf-probe updates
Date: Tue, 01 Dec 2009 07:30:00 -0000 [thread overview]
Message-ID: <20091201072902.GA4587@elte.hu> (raw)
In-Reply-To: <20091201001912.10235.79411.stgit@harusame>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Hi,
>
> Here are bugfixes and updates for perf-probe and kprobe-tracer. I've
> fixed some minor bugs and added --list option and simple probe naming.
Applied, thanks Masami!
> TODO:
> - Support build-id checking.
> - Support --del option to remove probes.
> - Support --line option to show which lines user can probe.
> - Support lazy string matching.
ok, cool!
One other small detail i noticed wrt. probe naming. Right now if we
insert a single probe into a function it gets named schedule_0:
# perf probe schedule
Could not open vmlinux/module file. Try to use symbols.
Added new event: p:probe/schedule_0 schedule+0
the next one gets named schedule_1, schedule_2, etc.
It would be nice to special-case the first one and name it 'schedule'.
Most of the time people insert a single probe into a function, so the _0
postfix is extra and in most cases unnecessary typing for them.
Another small detail is that i dont think we should emit this line:
Could not open vmlinux/module file. Try to use symbols.
when we can create a probe successfully - it's just unnecessary noise,
the user does not care how we pulled it off, as long as we were able to
get a reliable symbol address and the insertion worked fine.
A third detail is this line:
Added new event: p:probe/schedule_0 schedule+0
If that is pasted to perf stat directly it wont work because the syntax
is probe:schedule_0. So i'd suggest to print something like:
Added new event: probe/schedule_0 (on schedule+0)
Perhaps even print another line:
You can now use it on all perf tools, such as:
perf probe -e probe/schedule_0 -a sleep 1
perf record -e probe/schedule_0 -a sleep 1
... to show people how to make use of it.
Thanks,
Ingo
next prev parent reply other threads:[~2009-12-01 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 0:19 Masami Hiramatsu
2009-12-01 0:19 ` [PATCH -tip 1/9] trace_kprobes: Fix a memory leak bug and check kstrdup return value Masami Hiramatsu
2009-12-01 7:33 ` [tip:perf/core] trace_kprobes: Fix a memory leak bug and check kstrdup() " tip-bot for Masami Hiramatsu
2009-12-01 0:19 ` [PATCH -tip 5/9] perf probe: Fix probe array index for multiple probe point Masami Hiramatsu
2009-12-01 7:34 ` [tip:perf/core] perf probe: Fix probe array index for multiple probe points tip-bot for Masami Hiramatsu
2009-12-01 0:19 ` [PATCH -tip 3/9] perf probe: Fix to add probe-finder.h without libdwarf Masami Hiramatsu
2009-12-01 7:33 ` [tip:perf/core] perf probe: Add " tip-bot for Masami Hiramatsu
2009-12-01 0:19 ` [PATCH -tip 2/9] perf probe: Fix to change a debugging message from pr_info to pr_debug Masami Hiramatsu
2009-12-01 7:33 ` [tip:perf/core] perf probe: Change " tip-bot for Masami Hiramatsu
2009-12-01 0:19 ` [PATCH -tip 4/9] perf probe: Fix argv array size in probe parser Masami Hiramatsu
2009-12-01 7:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01 0:20 ` [PATCH -tip 9/9] perf probe: Simplify event naming Masami Hiramatsu
2009-12-01 7:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01 0:20 ` [PATCH -tip 6/9] perf probe: Move probe event utility functions to probe-event.c Masami Hiramatsu
2009-12-01 7:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01 0:20 ` [PATCH -tip 7/9] perf probe: Add argv_split() from lib/argv_split.c Masami Hiramatsu
2009-12-01 7:35 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01 0:20 ` [PATCH -tip 8/9] perf probe: Add --list option for listing current probe events Masami Hiramatsu
2009-12-01 7:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01 7:30 ` Ingo Molnar [this message]
2009-12-02 21:53 ` [PATCH -tip 0/9] perf-probe updates Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201072902.GA4587@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=peterz@infradead.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).