From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26791 invoked by alias); 1 Dec 2009 07:30:04 -0000 Received: (qmail 26765 invoked by uid 22791); 1 Dec 2009 07:30:02 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx3.mail.elte.hu (HELO mx3.mail.elte.hu) (157.181.1.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Dec 2009 07:29:57 +0000 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1NFNAb-0002yr-5X from ; Tue, 01 Dec 2009 08:29:30 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id 65CF53E22FA; Tue, 1 Dec 2009 08:29:00 +0100 (CET) Date: Tue, 01 Dec 2009 07:30:00 -0000 From: Ingo Molnar To: Masami Hiramatsu Cc: Frederic Weisbecker , lkml , Steven Rostedt , Jim Keniston , Ananth N Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , Jason Baron , "K.Prasad" , Peter Zijlstra , Srikar Dronamraju , Arnaldo Carvalho de Melo , systemtap , DLE Subject: Re: [PATCH -tip 0/9] perf-probe updates Message-ID: <20091201072902.GA4587@elte.hu> References: <20091201001912.10235.79411.stgit@harusame> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091201001912.10235.79411.stgit@harusame> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00756.txt.bz2 * Masami Hiramatsu wrote: > Hi, > > Here are bugfixes and updates for perf-probe and kprobe-tracer. I've > fixed some minor bugs and added --list option and simple probe naming. Applied, thanks Masami! > TODO: > - Support build-id checking. > - Support --del option to remove probes. > - Support --line option to show which lines user can probe. > - Support lazy string matching. ok, cool! One other small detail i noticed wrt. probe naming. Right now if we insert a single probe into a function it gets named schedule_0: # perf probe schedule Could not open vmlinux/module file. Try to use symbols. Added new event: p:probe/schedule_0 schedule+0 the next one gets named schedule_1, schedule_2, etc. It would be nice to special-case the first one and name it 'schedule'. Most of the time people insert a single probe into a function, so the _0 postfix is extra and in most cases unnecessary typing for them. Another small detail is that i dont think we should emit this line: Could not open vmlinux/module file. Try to use symbols. when we can create a probe successfully - it's just unnecessary noise, the user does not care how we pulled it off, as long as we were able to get a reliable symbol address and the insertion worked fine. A third detail is this line: Added new event: p:probe/schedule_0 schedule+0 If that is pasted to perf stat directly it wont work because the syntax is probe:schedule_0. So i'd suggest to print something like: Added new event: probe/schedule_0 (on schedule+0) Perhaps even print another line: You can now use it on all perf tools, such as: perf probe -e probe/schedule_0 -a sleep 1 perf record -e probe/schedule_0 -a sleep 1 ... to show people how to make use of it. Thanks, Ingo