From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: systemtap@sourceware.org
Cc: Jim Keniston <jkenisto@us.ibm.com>,
ananth@in.ibm.com, linuxppc-dev@ozlabs.org
Subject: [PATCH 1/4] powerpc: Fix thinko in _stp_arg()
Date: Thu, 03 Dec 2009 23:31:00 -0000 [thread overview]
Message-ID: <20091203233151.GA3416@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20091203233059.GA28186@oksana.dev.rtsoft.ru>
_stp_arg() has an almost unnoticeable thinko in the argnum handling,
which causes it to always return u_register("r10"):
'else (argnum == 8)' should actually be 'else if (argnum == 8)'.
Though, since we check for 'if (argnum < 1 || argnum > 8)' at the
beginning of _stp_arg(), let's make it just 'else'.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
tapset/powerpc/registers.stp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tapset/powerpc/registers.stp b/tapset/powerpc/registers.stp
index c8713e5..7f66d36 100644
--- a/tapset/powerpc/registers.stp
+++ b/tapset/powerpc/registers.stp
@@ -146,7 +146,7 @@ function _stp_arg:long (argnum:long, sign_extend:long, truncate:long) {
val = u_register("r8")
else if (argnum == 7)
val = u_register("r9")
- else (argnum == 8)
+ else
val = u_register("r10")
if (truncate) {
--
1.6.3.3
next prev parent reply other threads:[~2009-12-03 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 23:31 [PATCH 0/4] systemtap: Some more powerpc patches Anton Vorontsov
2009-12-03 23:31 ` Anton Vorontsov [this message]
2009-12-04 4:21 ` [PATCH 1/4] powerpc: Fix thinko in _stp_arg() Ananth N Mavinakayanahalli
2009-12-03 23:32 ` [PATCH 2/4] powerpc: Fix longlong args handling Anton Vorontsov
2009-12-03 23:32 ` [PATCH 4/4] powerpc: Improve backtrace output for ppc32 Anton Vorontsov
2009-12-03 23:32 ` [PATCH 3/4] powerpc: Adjust registers.stp " Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203233151.GA3416@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=ananth@in.ibm.com \
--cc=jkenisto@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).