From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
Jason Baron <jbaron@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint
Date: Sat, 05 Dec 2009 07:17:00 -0000 [thread overview]
Message-ID: <20091205071635.GB25383@elte.hu> (raw)
In-Reply-To: <4B17A1CD.8060706@redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Ingo Molnar wrote:
> >
> > * Masami Hiramatsu <mhiramat@redhat.com> wrote:
> >
> >> Add signal coredump tracepoint which shows signal number, mm->flags,
> >> limits, pointer to file structure and core file name.
> >
> > Why is the kernel pointer to the file structure logged? User-space has
> > no use for it and the analysis value is low.
>
> Ah, if open() or opening pipe fails, it becomes 0 or -ERRNO, so we can
> check if there is an error.
ok, that wasnt obvious from the patch - worth adding it to the
changelog.
> Perhaps, we can do below in trace_printk for trace users.
> "open %s", (!file || IS_ERR((void *)file)) ? "failed" : "succeeded"
i'd rather suggest to pass an error code (and keep it 0 if none),
instead of some ad-hoc string message.
But ... the whole issue of VFS event logging and new tracepoints should
be approached from a more generic direction i think. Do we want to log
inode_nr:dev pairs as well? Shouldnt there be a generic event-class
definition via DECLARE_EVENT_CLASS for file related events, with 'core
dumped' just being a sub-event-code?
I sense reluctance from the direction of Andrew and disinterest from the
VFS folks - not a good backdrop in general.
Ingo
next prev parent reply other threads:[~2009-12-05 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B128ECF.9020906@redhat.com>
2009-12-02 20:42 ` Masami Hiramatsu
2009-12-03 10:40 ` Ingo Molnar
2009-12-03 11:30 ` Masami Hiramatsu
2009-12-05 7:17 ` Ingo Molnar [this message]
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:35 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu
2009-12-09 20:34 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091205071635.GB25383@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).