public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	        lkml<linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	        Jim Keniston <jkenisto@us.ibm.com>,
	        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	        Christoph Hellwig <hch@infradead.org>,
	        "Frank Ch. Eigler" <fche@redhat.com>,
	        Frederic Weisbecker <fweisbec@gmail.com>,
	        Jason Baron <jbaron@redhat.com>,
	        "K.Prasad" <prasad@linux.vnet.ibm.com>,
	        Peter Zijlstra <peterz@infradead.org>,
	        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	        Arnaldo Carvalho de Melo <acme@redhat.com>,
	        systemtap<systemtap@sources.redhat.com>,
	        DLE<dle-develop@lists.sourceforge.net>
Subject: [PATCH -tip 4/8] perf probe: Remove event suffix number _0
Date: Tue, 08 Dec 2009 21:59:00 -0000	[thread overview]
Message-ID: <20091208220301.10142.50031.stgit@dhcp-100-2-132.bos.redhat.com> (raw)
In-Reply-To: <20091208220232.10142.2643.stgit@dhcp-100-2-132.bos.redhat.com>

Remove event suffix number _0 if it is the first.
The first event has no suffix, and from the second,
each event has suffix number counted from _1. This
reduces typing cost :-).

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Frank Ch. Eigler <fche@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: K.Prasad <prasad@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---

 tools/perf/util/probe-event.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 2c4d301..31beedc 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -466,7 +466,16 @@ static void get_new_event_name(char *buf, size_t len, const char *base,
 			       struct strlist *namelist)
 {
 	int i, ret;
-	for (i = 0; i < MAX_EVENT_INDEX; i++) {
+
+	/* Try no suffix */
+	ret = e_snprintf(buf, len, "%s", base);
+	if (ret < 0)
+		die("snprintf() failed: %s", strerror(-ret));
+	if (!strlist__has_entry(namelist, buf))
+		return;
+
+	/* Try to add suffix */
+	for (i = 1; i < MAX_EVENT_INDEX; i++) {
 		ret = e_snprintf(buf, len, "%s_%d", base, i);
 		if (ret < 0)
 			die("snprintf() failed: %s", strerror(-ret));


-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

  parent reply	other threads:[~2009-12-08 21:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 21:58 [PATCH -tip 0/8] perf-probe updates Masami Hiramatsu
2009-12-08 21:58 ` [PATCH -tip 3/8] perf probe: Fix add-probe command syntax without --add option Masami Hiramatsu
2009-12-09  7:28   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:58 ` [PATCH -tip 5/8] perf probe: Support vmlinux on cwd by default Masami Hiramatsu
2009-12-09  7:27   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:58 ` [PATCH -tip 2/8] perf probe: Change probe-added message more user-friendly Masami Hiramatsu
2009-12-09  7:27   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:58 ` [PATCH -tip 1/8] perf probe: Change event list format Masami Hiramatsu
2009-12-09  7:28   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:58 ` [PATCH -tip 6/8] trace-kprobe: Support delete probe syntax Masami Hiramatsu
2009-12-09  7:27   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:59 ` [PATCH -tip 7/8] perf probe: Support --del option Masami Hiramatsu
2009-12-09  7:27   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-08 21:59 ` Masami Hiramatsu [this message]
2009-12-09  7:29   ` [tip:perf/urgent] perf probe: Remove event suffix number _0 tip-bot for Masami Hiramatsu
2009-12-08 21:59 ` [PATCH -tip 8/8] perf probe: Update perf-probe document Masami Hiramatsu
2009-12-09  7:28   ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
2009-12-09  7:22 ` [PATCH -tip 0/8] perf-probe updates Ingo Molnar
2009-12-09  8:44   ` Ingo Molnar
2009-12-09 17:36     ` Masami Hiramatsu
2009-12-09 21:41       ` Masami Hiramatsu
2009-12-11 20:51         ` Arnaldo Carvalho de Melo
2009-12-11 21:15           ` Masami Hiramatsu
2009-12-11 21:29             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091208220301.10142.50031.stgit@dhcp-100-2-132.bos.redhat.com \
    --to=mhiramat@redhat.com \
    --cc=acme@redhat.com \
    --cc=ananth@in.ibm.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=jbaron@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=prasad@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).