From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20385 invoked by alias); 9 Dec 2009 07:22:59 -0000 Received: (qmail 20377 invoked by uid 22791); 9 Dec 2009 07:22:58 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx3.mail.elte.hu (HELO mx3.mail.elte.hu) (157.181.1.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Dec 2009 07:22:53 +0000 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1NIGsS-0008RV-5R from ; Wed, 09 Dec 2009 08:22:24 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id A09FB3E22E0; Wed, 9 Dec 2009 08:22:21 +0100 (CET) Date: Wed, 09 Dec 2009 07:22:00 -0000 From: Ingo Molnar To: Masami Hiramatsu Cc: Frederic Weisbecker , lkml , Steven Rostedt , Jim Keniston , Ananth N Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , Jason Baron , "K.Prasad" , Peter Zijlstra , Srikar Dronamraju , Arnaldo Carvalho de Melo , systemtap , DLE Subject: Re: [PATCH -tip 0/8] perf-probe updates Message-ID: <20091209072220.GA4328@elte.hu> References: <20091208220232.10142.2643.stgit@dhcp-100-2-132.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091208220232.10142.2643.stgit@dhcp-100-2-132.bos.redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00846.txt.bz2 * Masami Hiramatsu wrote: > Hi Ingo, > > I made several usability updates and added --del option > for perf-probe. I think most of basic functions are implemented. > I'm planning to support checking build-id next, because it > can prevent users to use old vmlinux for debuginfo analysis. > > Here are the todo list I have (most of them had been requested > on LKML). I'd like to share this list with other developers > who are interested in. > > Short-term TODOs: > - Support checking kernel Build-ID > > Long-term TODOs (future features): > - Support --line option to show which lines user can probe > - Support lazy string matching(glob?) for selecting probing > line > - Support sys_perf_counter_open (for non-root users) > - Support tracing static variables (non global) > - Support variable types from debuginfo (e.g. char, int, ...) > - Support fields of data structures (var->field) > - Support array (var[N]) > - Support dynamic array-indexing (var[var2]) > - Support string/dynamic arrays (*var, var[N..M]) > - Support force type-casting ((type)var) > - Support the type of return value > > Miscs: > - Support glob expression with --del option (like --del "*") > - Support event/group name specifying for new events > - Better support for probes on modules > - Symbol search by libelf/kallsyms > - Move onto libdw/libdwfl > - Storing file name/line number information in the > kernel for listing events > > > Thank you, > > --- > > Masami Hiramatsu (8): > perf probe: Update perf-probe document > perf probe: Support --del option > trace-kprobe: Support delete probe syntax > perf probe: Support vmlinux on cwd by default > perf probe: Remove event suffix number _0 > perf probe: Fix add-probe command syntax without --add option > perf probe: Change probe-added message more user-friendly > perf probe: Change event list format > > > kernel/trace/trace_kprobe.c | 37 +++++++-- > tools/perf/Documentation/perf-probe.txt | 21 ++++- > tools/perf/builtin-probe.c | 76 ++++++++++++++++--- > tools/perf/util/probe-event.c | 122 ++++++++++++++++++++++++++++--- > tools/perf/util/probe-event.h | 1 > 5 files changed, 217 insertions(+), 40 deletions(-) Applied - thanks Masami! These are very nice enhancements. I tried out the new features and they worked well, and the use of the tool is intuitive. One hickup is that -d/--del does not appear to be working yet: # perf probe -l probe:schedule (on schedule) # perf probe -d probe:schedule Fatal: Failed to write event: Invalid argument Ingo