[Bug testsuite/10732] New: declaration.exp empty-struct always fails, resolve-fail passes erroneously

[Bug testsuite/10732] New: declaration.exp empty-struct always fails, resolve-fail passes erroneously

[mjw at redhat dot com]

The declaration.exp testcases rely on kernel module function probe points that
don't exist in modern kernels. It would be better to rewrite these as user space
tests, so the testsuite controls all inputs.

Running /home/mark/src/systemtap/testsuite/systemtap.base/declaration.exp ...
running stap -v -p4 -e probe\ module(\"libata\").function(\"ata_qc_issue\")\ \{\
print(\$qc->\$scsicmd->\$device->\$host->\$host_no)\ \};
Pass 1: parsed user script and 60 library script(s) using
19364virt/11576res/2096shr kb, in 120usr/10sys/130real ms.
semantic error: no match while resolving probe point
module("libata").function("ata_qc_issue")
Pass 2: analyzed script: 0 probe(s), 0 function(s), 0 embed(s), 0 global(s)
using 136912virt/12392res/2488shr kb, in 20usr/60sys/88real ms.
Pass 2: analysis failed.  Try again with another '--vp 01' option.
PASS: empty-struct resolve-fail compilation failed correctly
running stap -v -p4 -e probe\
module(\"scsi_mod\").function(\"scsi_request_fn\")\ \{print(\$q)\} probe\
module(\"libata\").function(\"ata_qc_issue\")\ \{\
print(\$qc->\$scsicmd->\$device->\$host->\$host_no)\ \};
Pass 1: parsed user script and 60 library script(s) using
19364virt/11576res/2096shr kb, in 120usr/10sys/140real ms.
semantic error: no match while resolving probe point
module("scsi_mod").function("scsi_request_fn")
Pass 2: analyzed script: 0 probe(s), 0 function(s), 0 embed(s), 0 global(s)
using 136912virt/12388res/2488shr kb, in 20usr/70sys/91real ms.
Pass 2: analysis failed.  Try again with another '--vp 01' option.
FAIL: empty-struct resolve-pass compilation failed

-- 
           Summary: declaration.exp empty-struct always fails, resolve-fail
                    passes erroneously
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mjw at redhat dot com
                CC: jistone at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10732

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10732] declaration.exp empty-struct always fails, resolve-fail passes erroneously

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-10-06 02:38 -------
This seems to be testing that one module can implicitly provide a struct
declaration for a probe in some other module.  IIRC, we decided against this
"global type" behavior, opting instead to go with explicit @casts where necessary...

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10732

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10732] declaration.exp empty-struct always fails, resolve-fail passes erroneously

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-12-28 11:13 -------
For now I XFAILed this test. But maybe it should be removed completely?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10732

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10732] declaration.exp empty-struct always fails, resolve-fail passes erroneously

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-01-04 15:24 -------
I'm thinking it should be removed.

If we want to test that one module can implicitly provide a struct
declaration for a probe in some other module, the safest way might be to
write/compile/install a couple of custom kernel modules.  But, that seems like
overkill for a situation that '@cast' is designed to solve.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10732

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/10732] declaration.exp empty-struct always fails, resolve-fail passes erroneously

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2010-01-05 10:46 -------
(In reply to comment #3)
> I'm thinking it should be removed.

OK, I removed the test completely.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10732

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.