* [PATCH -tip 1/2] kprobetrace, doc: shell need single quote to use $ character
[not found] <20100117071411.GD19512@elte.hu>
2010-01-19 2:34 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
@ 2010-01-19 2:34 ` Masami Hiramatsu
1 sibling, 0 replies; 8+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 2:34 UTC (permalink / raw)
To: Ingo Molnar, lkml; +Cc: systemtap, DLE, KOSAKI Motohiro, Masami Hiramatsu
From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
shell interpret $val is as shell variable. thus we need quote if
we use echo command.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index f30978e..ab57f02 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -79,7 +79,7 @@ Usage examples
To add a probe as a new event, write a new definition to kprobe_events
as below.
- echo p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack) > /sys/kernel/debug/tracing/kprobe_events
+ echo 'p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack)' > /sys/kernel/debug/tracing/kprobe_events
This sets a kprobe on the top of do_sys_open() function with recording
1st to 4th arguments as "myprobe" event. Note, which register/stack entry is
@@ -88,7 +88,7 @@ the ABI, please try to use probe subcommand of perf-tools (you can find it
under tools/perf/).
As this example shows, users can choose more familiar names for each arguments.
- echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
+ echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
This sets a kretprobe on the return point of do_sys_open() function with
recording return value as "myretprobe" event.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
[not found] <20100117071411.GD19512@elte.hu>
@ 2010-01-19 2:34 ` Masami Hiramatsu
2010-01-19 2:46 ` Li Zefan
2010-01-19 4:19 ` Masami Hiramatsu
2010-01-19 2:34 ` [PATCH -tip 1/2] kprobetrace, doc: shell need single quote to use $ character Masami Hiramatsu
1 sibling, 2 replies; 8+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 2:34 UTC (permalink / raw)
To: Ingo Molnar, lkml; +Cc: systemtap, DLE, KOSAKI Motohiro, Masami Hiramatsu
From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
Latest kprobetrace can remove probe points selectively. thus
documentation should be updated too.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index ab57f02..a9100b2 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -24,6 +24,7 @@ Synopsis of kprobe_events
-------------------------
p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
+ -:[GRP/]EVENT : Clear a probe
GRP : Group name. If omitted, use "kprobes" for it.
EVENT : Event name. If omitted, the event name is generated
@@ -122,6 +123,12 @@ REC->dfd, REC->filename, REC->flags, REC->mode
This clears all probe points.
+ Or,
+
+ echo -:myprobe >> kprobe_events
+
+ This clears probe points selectively.
+
Right after definition, each event is disabled by default. For tracing these
events, you need to enable it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:34 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
@ 2010-01-19 2:46 ` Li Zefan
2010-01-19 3:02 ` Masami Hiramatsu
2010-01-19 4:19 ` Masami Hiramatsu
1 sibling, 1 reply; 8+ messages in thread
From: Li Zefan @ 2010-01-19 2:46 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>
> Latest kprobetrace can remove probe points selectively. thus
> documentation should be updated too.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
You should add your sob instead of ack. :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:46 ` Li Zefan
@ 2010-01-19 3:02 ` Masami Hiramatsu
2010-01-19 3:05 ` Li Zefan
0 siblings, 1 reply; 8+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 3:02 UTC (permalink / raw)
To: Li Zefan; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Li Zefan wrote:
> Masami Hiramatsu wrote:
>> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>>
>> Latest kprobetrace can remove probe points selectively. thus
>> documentation should be updated too.
>>
>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> You should add your sob instead of ack. :)
Ah, I didn't change anything on this patch.
Just resent :-)
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 3:02 ` Masami Hiramatsu
@ 2010-01-19 3:05 ` Li Zefan
2010-01-19 4:18 ` Masami Hiramatsu
0 siblings, 1 reply; 8+ messages in thread
From: Li Zefan @ 2010-01-19 3:05 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> Li Zefan wrote:
>> Masami Hiramatsu wrote:
>>> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>>>
>>> Latest kprobetrace can remove probe points selectively. thus
>>> documentation should be updated too.
>>>
>>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>> You should add your sob instead of ack. :)
>
> Ah, I didn't change anything on this patch.
> Just resent :-)
>
Still you should add your sob, since you are delivering the patch,
Andrew one reminded me on this. Also you can refer to
Documentation/SubmittingPatches:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 3:05 ` Li Zefan
@ 2010-01-19 4:18 ` Masami Hiramatsu
0 siblings, 0 replies; 8+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 4:18 UTC (permalink / raw)
To: systemtap
Li Zefan wrote:
> Masami Hiramatsu wrote:
>> Li Zefan wrote:
>>> Masami Hiramatsu wrote:
>>>> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>>>>
>>>> Latest kprobetrace can remove probe points selectively. thus
>>>> documentation should be updated too.
>>>>
>>>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>>>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>>> You should add your sob instead of ack. :)
>>
>> Ah, I didn't change anything on this patch.
>> Just resent :-)
>>
>
> Still you should add your sob, since you are delivering the patch,
> Andrew one reminded me on this. Also you can refer to
> Documentation/SubmittingPatches:
>
> The Signed-off-by: tag indicates that the signer was involved in the
> development of the patch, or that he/she was in the patch's delivery path.
Oh, thank you for telling it.
OK, I'll add it. :-)
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:34 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
2010-01-19 2:46 ` Li Zefan
@ 2010-01-19 4:19 ` Masami Hiramatsu
2010-01-20 6:19 ` Ingo Molnar
1 sibling, 1 reply; 8+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 4:19 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>
> Latest kprobetrace can remove probe points selectively. thus
> documentation should be updated too.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Since I've delivered this patch.:-)
> ---
>
> Documentation/trace/kprobetrace.txt | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
> index ab57f02..a9100b2 100644
> --- a/Documentation/trace/kprobetrace.txt
> +++ b/Documentation/trace/kprobetrace.txt
> @@ -24,6 +24,7 @@ Synopsis of kprobe_events
> -------------------------
> p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
> r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
> + -:[GRP/]EVENT : Clear a probe
>
> GRP : Group name. If omitted, use "kprobes" for it.
> EVENT : Event name. If omitted, the event name is generated
> @@ -122,6 +123,12 @@ REC->dfd, REC->filename, REC->flags, REC->mode
>
> This clears all probe points.
>
> + Or,
> +
> + echo -:myprobe >> kprobe_events
> +
> + This clears probe points selectively.
> +
> Right after definition, each event is disabled by default. For tracing these
> events, you need to enable it.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 4:19 ` Masami Hiramatsu
@ 2010-01-20 6:19 ` Ingo Molnar
0 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2010-01-20 6:19 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: lkml, systemtap, DLE, KOSAKI Motohiro
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Masami Hiramatsu wrote:
> > From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
> >
> > Latest kprobetrace can remove probe points selectively. thus
> > documentation should be updated too.
> >
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Since I've delivered this patch.:-)
Correct - thanks guys!
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-01-20 6:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20100117071411.GD19512@elte.hu>
2010-01-19 2:34 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
2010-01-19 2:46 ` Li Zefan
2010-01-19 3:02 ` Masami Hiramatsu
2010-01-19 3:05 ` Li Zefan
2010-01-19 4:18 ` Masami Hiramatsu
2010-01-19 4:19 ` Masami Hiramatsu
2010-01-20 6:19 ` Ingo Molnar
2010-01-19 2:34 ` [PATCH -tip 1/2] kprobetrace, doc: shell need single quote to use $ character Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).