[Bug translator/10257] New: sprint(@hist_*) doesn't parse

[Bug translator/10257] New: sprint(@hist_*) doesn't parse

[fche at redhat dot com]

In parser.cxx:parse_symbol() processes many variants of
*print* and @stat ops, but the code is missing the sprint*
variants.  See line 2421.

global foo
probe begin { foo <<< 1 }
probe end { log(sprint(@hist_log(foo)) }

-- 
           Summary: sprint(@hist_*) doesn't parse
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10257

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10257] sprint(@hist_*) doesn't parse

[przemyslaw at pawelczyk dot it]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |przemyslaw at pawelczyk dot
                   |                            |it


http://sourceware.org/bugzilla/show_bug.cgi?id=10257

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10257] sprint(@hist_*) doesn't parse

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-09-16 08:06 -------
The key is to make a function like _stp_stat_print_histogram_buf 

static void _stp_stat_print_histogram_buf (char *buf, Hist st, stat *sd)

Do same job as the origin one, but print histogram into buf.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10257

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10257] sprint(@hist_*) doesn't parse

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2010-02-04 08:35 -------
See the implementation.

commit b15c465c2238a4414925c8f6bce15c89bdd93e44
Author: Przemyslaw Pawelczyk <przemyslaw@pawelczyk.it>
Date:   Tue Oct 13 14:44:29 2009 +0200

    PR10257: Add support for sprint[ln](@hist_*).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10257

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10257] sprint(@hist_*) doesn't parse

[przemyslaw at pawelczyk dot it]

------- Additional Comments From przemyslaw at pawelczyk dot it  2010-02-11 21:58 -------
Following commits allow us to close this:

b15c465 PR10257: Add support for sprint[ln](@hist_*).
334d767 Add buildok tests for sprint[ln](@hist_*)
42b2e52 Refactor some of the histogram printing
84b4973 Add simple test for PR10257 (sprint(@hist_linear)).

It's worth to explicitly mention that this feature is already available in v1.1, 
but PR wasn't fully closed due to lack of the test (other than buildok one).

Other thing is that sprint[ln](@hist_*) is useless without setting appropriate 
MAXSTRINGLEN (i.e. bigger than default 256/512, e.g. 4096), but when PR10690 
will be solved (and suitable modification of sprint[ln](@hist_*) applied), then 
we'll be freed from playing with defines, at least in one (but important) case.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10257

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.