[Bug translator/11201] New: Distributed scripts should not be removed on clean

[Bug translator/11201] New: Distributed scripts should not be removed on clean

[eugen at debian dot org]

Currently for some unknown to me reason toplevel Makefile removes some scripts
(pkglibexec_SCRIPTS) in "clean" target. This should not be done because they
cannot be restored (as far as I can see, otherwise they should not be
distributed at all).

-- 
           Summary: Distributed scripts should not be removed on clean
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: eugen at debian dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=11201

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11201] Distributed scripts should not be removed on clean

[eugen at debian dot org]

------- Additional Comments From eugen at debian dot org  2010-01-21 09:08 -------
Created an attachment (id=4546)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4546&action=view)
Patch

I don't commit this patch myself because I'm not sure why that variable was
set. Also I have no idea why is pkglibexec_PROGRAMS is there.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11201

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11201] Distributed scripts should not be removed on clean

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2010-01-21 09:39 -------
It was introduced a long time ago to support building elfutils inside systemtap.
Maybe Roland can help figure out if the current usage still matches to original
intent.

commit e460639fa72fda6ff89bb77ab48516f6f478c909
Author: roland <roland>
Date:   Mon Dec 12 05:52:00 2005 +0000

    2005-12-11  Roland McGrath  <roland@redhat.com>
    
        PR 1916
        * configure.ac: Grok --with-elfutils.
        * Makefile.am [BUILD_ELFUTILS] (install-elfutils, stamp-elfutils):
        New targets.
        [BUILD_ELFUTILS] (stap_LDFLAGS, stap_LDFLAGS): Add flags
        to point at local elfutils build.
        [BUILD_ELFUTILS] (BUILT_SOURCES): Add stamp-elfutils.
        [BUILD_ELFUTILS] (stap_DEPENDENCIES): New variable.
        [BUILD_ELFUTILS] (lib-elfutils/libdw.so): New target.
        [BUILD_ELFUTILS] (install-exec-local): Depend on install-elfutils.
        (loc2c_test_LDADD): Set this to $(stap_LDADD).
        (loc2c_test_CPPFLAGS, loc2c_test_LDFLAGS): New variables.
        * Makefile.in: Regenerated.
        * compile: New file from automakeland.
        * systemtap.spec.in (elfutils_version): Require 0.118 or later.
        [bundled_elfutils]: Remove old hacks for building elfutils, and rely
        on configure --with-elfutils instead.
        * Makefile.am (pkglibexecdir): New variable.
        (AM_CPPFLAGS): Use it.
        (pkglibexec_PROGRAMS): Set this instead of noinst_PROGRAMS with stpd.
        (pkglibexec_SCRIPTS, CLEANFILES): New variables.
        (install-exec-local): Target removed.
        * runtest.sh: Set LD_LIBRARY_PATH when lib-elfutils is in use.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roland at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11201

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11201] Distributed scripts should not be removed on clean

[brolley at redhat dot com]

------- Additional Comments From brolley at redhat dot com  2010-01-21 16:52 -------
(In reply to comment #1)
> Created an attachment (id=4546)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4546&action=view)
> Patch
> 
> I don't commit this patch myself because I'm not sure why that variable was
> set.

Thanks. I've committed your patch.

> Also I have no idea why is pkglibexec_PROGRAMS is there.

In addition to what Mark said, it is now being used for stap-sign-module,
stap-client-connect and stap-server-connect which are present at the root of the
build tree and are now installed in libexec/systemtap as per bugs 10247 and 10276.



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=11201

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11201] Distributed scripts should not be removed on clean

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2010-02-26 14:29 -------
committed

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11201

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.