public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "mjw at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug tapsets/11388] New: syscall.mmap* probes versus 2.6.33+ kernels
Date: Tue, 16 Mar 2010 16:42:00 -0000	[thread overview]
Message-ID: <20100316164239.11388.mjw@redhat.com> (raw)

Recent kernels saw some cleanups of the mmap implementation code. The systemtap
syscall tapsets should be updated to match.

The mmap syscalls are traditionally architecture specific because different
architectures used different implementation strategies, so had different entry
points. So look for the tapset aliases under tapset/<arch>/syscall.stp. The main
differences were because on some architectures not all arguments could be passed
in registers, so the arguments were passed in as one argument to a struct. Some
architectures even had both variants of the syscall. i386 for example has
syscall number 90 mmap, which takes a struct, and syscall number 192 mmap2,
which takes 6 arguments).

On different architectures either variant might exist and mapped to different
implementation function names. Recent cleanups (some only in recent git, not yet
released) map them to more consistent names (sys_old_mmap and sys_mmap_pgoff)

The relevant kernel commits are:

unreleased kernel:

commit a4679373cf4ee0e7792dc56205365732b725c2c1
Author: Christoph Hellwig <hch@lst.de>
Date:   Wed Mar 10 15:21:15 2010 -0800

    Add generic sys_old_mmap()
    
    Add a generic implementation of the old mmap() syscall, which expects its
    argument in a memory block and switch all architectures over to use it.

2.6.33 kernel:

commit f8b7256096a20436f6d0926747e3ac3d64c81d24
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Mon Nov 30 17:37:04 2009 -0500

    Unify sys_mmap*
    
    New helper - sys_mmap_pgoff(); switch syscalls to using it.
    
    Acked-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

-- 
           Summary: syscall.mmap* probes versus 2.6.33+ kernels
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mjw at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11388

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

             reply	other threads:[~2010-03-16 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 16:42 mjw at redhat dot com [this message]
2010-03-17 16:10 ` [Bug tapsets/11388] " dsmith at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316164239.11388.mjw@redhat.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).