From: "wenji dot huang at oracle dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug runtime/11325] Spaces and exclamation marks invalid as module arguments
Date: Thu, 18 Mar 2010 08:10:00 -0000 [thread overview]
Message-ID: <20100318081039.644.qmail@sourceware.org> (raw)
In-Reply-To: <20100225211044.11325.chwang@redhat.com>
------- Additional Comments From wenji dot huang at oracle dot com 2010-03-18 08:10 -------
(In reply to comment #0)
> Examples:
>
> $ stap -p4 -m mod1 -e 'global var1="foo"; probe begin{printf("%s\n", var1);
> exit()}'
>
> $ staprun mod1.ko var1="hello!"
> bash: !": event not found
...
> Also, escaping the exclamation mark results in the escape character also being
> printed:
> $ staprun mod1.ko var1="hello\!"
> hello\!
Same results as bash,
$ echo "foo!"
-bash: !": event not found
$ echo "foo\!"
foo\!
> $ staprun mod1.ko var1="hello world"
> Error inserting module '/notnfs/chwang/systemtap/mod1.ko': Unknown symbol in
module
> Retrying, after attempted removal of module mod1 (rc -1)
> Error inserting module '/notnfs/chwang/systemtap/mod1.ko': Unknown symbol in
module
Seems a bug, maybe fixed by the following patch.
$staprun mod1.ko var1="hello foo"
hello foo
diff --git a/runtime/staprun/staprun_funcs.c b/runtime/staprun/staprun_funcs.c
index db58cd4..2f8076a 100644
--- a/runtime/staprun/staprun_funcs.c
+++ b/runtime/staprun/staprun_funcs.c
@@ -68,13 +68,14 @@ int insert_module(
return -1;
}
for (i = 0; options[i] != NULL; i++) {
- opts = realloc(opts, strlen(opts) + strlen(options[i]) + 2);
+ opts = realloc(opts, strlen(opts) + strlen(options[i]) + 4);
if (opts == NULL) {
_perr("[re]allocating memory failed");
return -1;
}
- strcat(opts, " ");
+ strcat(opts, " \"");
strcat(opts, options[i]);
+ strcat(opts, "\"");
}
dbug(2, "module options: %s\n", opts);
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11325
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2010-03-18 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 21:11 [Bug runtime/11325] New: " chwang at redhat dot com
2010-03-18 8:10 ` wenji dot huang at oracle dot com [this message]
2010-03-18 15:10 ` [Bug runtime/11325] " fche at redhat dot com
2010-03-19 2:19 ` wenji dot huang at oracle dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318081039.644.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).