From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-15503-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 5107 invoked by alias); 19 Mar 2010 13:35:18 -0000
Received: (qmail 5083 invoked by uid 22791); 19 Mar 2010 13:35:18 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Mar 2010 13:35:13 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2JDZBkA001777 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <systemtap@sources.redhat.com>; Fri, 19 Mar 2010 09:35:11 -0400
Received: from tranklukator.englab.brq.redhat.com (vpn1-6-254.ams2.redhat.com [10.36.6.254]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id o2JDZ8fF008993; 	Fri, 19 Mar 2010 09:35:09 -0400
Received: by tranklukator.englab.brq.redhat.com (nbSMTP-1.00) for uid 500 	onestero@redhat.com; Fri, 19 Mar 2010 14:33:55 +0100 (CET)
Date: Fri, 19 Mar 2010 13:35:00 -0000
From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>,         DLE <dle-develop@lists.sourceforge.net>,         Roland McGrath <roland@redhat.com>, Jason Baron <jbaron@redhat.com>,         Andrew Morton <akpm@linux-foundation.org>,         KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,         Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH -tip v5] tracepoint: Add signal coredump tracepoint
Message-ID: <20100319133352.GC19394@redhat.com>
References: <20100319132346.31144.40337.stgit@localhost6.localdomain6>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100319132346.31144.40337.stgit@localhost6.localdomain6>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2010-q1/txt/msg00714.txt.bz2

(add Neil)

On 03/19, Masami Hiramatsu wrote:
>
>  void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  {
>  	struct core_state core_state;
> -	char corename[CORENAME_MAX_SIZE + 1];
> +	char corename[CORENAME_MAX_SIZE + 1] = "";
>  	struct mm_struct *mm = current->mm;
>  	struct linux_binfmt * binfmt;
>  	struct inode * inode;
> @@ -1802,6 +1803,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  	static atomic_t core_dump_count = ATOMIC_INIT(0);
>  	struct coredump_params cprm = {
>  		.signr = signr,
> +		.file = NULL,
>  		.regs = regs,
>  		.limit = rlimit(RLIMIT_CORE),
>  		/*
> @@ -1815,8 +1817,10 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  	audit_core_dumps(signr);
>
>  	binfmt = mm->binfmt;
> -	if (!binfmt || !binfmt->core_dump)
> +	if (!binfmt || !binfmt->core_dump) {
> +		retval = -ENOSYS;
>  		goto fail;
> +	}

Oh.

Masami, may I ask you to delay these changes a bit?

This patch conflicts very much with other changes (hopefully in -mm soon)
we are doing.

If your patch comes first, we have to redo 12 patches. Besides, this patch
complicates do_coredump() even more while it really needs the cleanups.

Please see
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/96f01d85034ca029/3b6bcb9b2d756dbc
I can send you these patches privately if you wish.

Oleg.