* [Bug runtime/11078] New: avoid procfs race condition
@ 2009-12-10 17:07 dsmith at redhat dot com
2010-01-19 16:51 ` [Bug runtime/11078] " fche at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2009-12-10 17:07 UTC (permalink / raw)
To: systemtap
Using create_proc_entry() + ->proc_fops assignment is racy because
->proc_fops will be NULL for some time. To avoid this, we need to use
proc_create().
This would change something like:
struct proc_dir_entry *entry;
entry = create_proc_entry("foo", 0, NULL);
if (entry)
entry->proc_fops = &file_ops;
To something like:
struct proc_dir_entry *entry;
entry = proc_create("foo", 0, NULL, &file_ops);
This will require re-architecting the _stp_create_procfs() runtime function (in
runtime/procfs.c) a bit to take a fops argument.
--
Summary: avoid procfs race condition
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: dsmith at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=11078
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug runtime/11078] avoid procfs race condition
2009-12-10 17:07 [Bug runtime/11078] New: avoid procfs race condition dsmith at redhat dot com
@ 2010-01-19 16:51 ` fche at redhat dot com
2010-02-03 17:58 ` dsmith at redhat dot com
2010-03-23 21:17 ` fche at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: fche at redhat dot com @ 2010-01-19 16:51 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |11179
nThis| |
http://sourceware.org/bugzilla/show_bug.cgi?id=11078
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug runtime/11078] avoid procfs race condition
2009-12-10 17:07 [Bug runtime/11078] New: avoid procfs race condition dsmith at redhat dot com
2010-01-19 16:51 ` [Bug runtime/11078] " fche at redhat dot com
@ 2010-02-03 17:58 ` dsmith at redhat dot com
2010-03-23 21:17 ` fche at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2010-02-03 17:58 UTC (permalink / raw)
To: systemtap
------- Additional Comments From dsmith at redhat dot com 2010-02-03 17:57 -------
Fixed in commit 23b7dbf.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=11078
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug runtime/11078] avoid procfs race condition
2009-12-10 17:07 [Bug runtime/11078] New: avoid procfs race condition dsmith at redhat dot com
2010-01-19 16:51 ` [Bug runtime/11078] " fche at redhat dot com
2010-02-03 17:58 ` dsmith at redhat dot com
@ 2010-03-23 21:17 ` fche at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: fche at redhat dot com @ 2010-03-23 21:17 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|11179 |
nThis| |
http://sourceware.org/bugzilla/show_bug.cgi?id=11078
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-23 21:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-10 17:07 [Bug runtime/11078] New: avoid procfs race condition dsmith at redhat dot com
2010-01-19 16:51 ` [Bug runtime/11078] " fche at redhat dot com
2010-02-03 17:58 ` dsmith at redhat dot com
2010-03-23 21:17 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).