public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug tapsets/11480] New: bad kfail for rpc-all-probes.stp test
@ 2010-04-08 20:24 dsmith at redhat dot com
  2010-04-08 20:25 ` [Bug tapsets/11480] " dsmith at redhat dot com
  0 siblings, 1 reply; 2+ messages in thread
From: dsmith at redhat dot com @ 2010-04-08 20:24 UTC (permalink / raw)
  To: systemtap

testsuite/systemtap.pass1-4/buildok.exp "kfails" (marks as a known failure)
buildok/rpc-all-probes.stp because of bug 4413.  While the rpc.stp tapset does
have at least one problem related to that bug, the real problems with the
rpc.stp tapset are due to not handling kernel changes correctly.

The "kfail" is hiding real problems with the rpc tapset.

For instance, the prototype of rpc_new_client() has changed from:

static struct rpc_clnt *
rpc_new_client(struct rpc_xprt *xprt, char *servname,
    struct rpc_program *program, u32 vers,
    rpc_authflavor_t flavor);

to:

static struct rpc_clnt *
rpc_new_client(const struct rpc_create_args *args, struct rpc_xprt *xprt);

But, the sunrpc.clnt.create_client probe is unaware of this change.

The buildok/rpc-all-probes.stp test needs to be unmarked as a 'kfail' (and
improved) and the rpc.stp tapset needs to be updated.

-- 
           Summary: bad kfail for rpc-all-probes.stp test
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: dsmith at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11480

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug tapsets/11480] bad kfail for rpc-all-probes.stp test
  2010-04-08 20:24 [Bug tapsets/11480] New: bad kfail for rpc-all-probes.stp test dsmith at redhat dot com
@ 2010-04-08 20:25 ` dsmith at redhat dot com
  0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2010-04-08 20:25 UTC (permalink / raw)
  To: systemtap



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |dsmith at redhat dot com
                   |redhat dot com              |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=11480

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-08 20:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-08 20:24 [Bug tapsets/11480] New: bad kfail for rpc-all-probes.stp test dsmith at redhat dot com
2010-04-08 20:25 ` [Bug tapsets/11480] " dsmith at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).