From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18062 invoked by alias); 10 May 2010 18:37:16 -0000 Received: (qmail 18055 invoked by uid 22791); 10 May 2010 18:37:15 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from tx2ehsobe001.messaging.microsoft.com (HELO TX2EHSOBE001.bigfish.com) (65.55.88.11) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 May 2010 18:37:06 +0000 Received: from mail171-tx2-R.bigfish.com (10.9.14.249) by TX2EHSOBE001.bigfish.com (10.9.40.21) with Microsoft SMTP Server id 8.1.340.0; Mon, 10 May 2010 18:37:04 +0000 Received: from mail171-tx2 (localhost.localdomain [127.0.0.1]) by mail171-tx2-R.bigfish.com (Postfix) with ESMTP id 0D4BF418326; Mon, 10 May 2010 18:37:04 +0000 (UTC) X-SpamScore: -21 X-BigFish: VPS-21(zz1432P98dN936eM62a3L7cf0izz1202hzzz32i2a8h61h) X-Spam-TCS-SCL: 0:0 Received: from mail171-tx2 (localhost.localdomain [127.0.0.1]) by mail171-tx2 (MessageSwitch) id 127351662234100_13573; Mon, 10 May 2010 18:37:02 +0000 (UTC) Received: from TX2EHSMHS023.bigfish.com (unknown [10.9.14.250]) by mail171-tx2.bigfish.com (Postfix) with ESMTP id D7B4A270052; Mon, 10 May 2010 18:37:01 +0000 (UTC) Received: from ausb3extmailp02.amd.com (163.181.251.22) by TX2EHSMHS023.bigfish.com (10.9.99.123) with Microsoft SMTP Server (TLS) id 14.0.482.44; Mon, 10 May 2010 18:37:00 +0000 Received: from ausb3twp01.amd.com (ausb3twp01.amd.com [163.181.250.37]) by ausb3extmailp02.amd.com (Switch-3.2.7/Switch-3.2.7) with SMTP id o4AIc9Sn011195; Mon, 10 May 2010 13:38:12 -0500 X-M-MSG: Received: from sausexhtp02.amd.com (sausexhtp02.amd.com [163.181.3.152]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ausb3twp01.amd.com (Tumbleweed MailGate 3.7.2) with ESMTP id 243B11028717; Mon, 10 May 2010 13:36:53 -0500 (CDT) Received: from storexhtp02.amd.com (172.24.4.4) by sausexhtp02.amd.com (163.181.3.152) with Microsoft SMTP Server (TLS) id 8.2.234.1; Mon, 10 May 2010 13:36:56 -0500 Received: from gwo.osrc.amd.com (165.204.16.204) by storexhtp02.amd.com (172.24.4.4) with Microsoft SMTP Server id 8.2.234.1; Mon, 10 May 2010 14:36:55 -0400 Received: from erda.amd.com (erda.osrc.amd.com [165.204.15.17]) by gwo.osrc.amd.com (Postfix) with ESMTP id 3DC0249C1AD; Mon, 10 May 2010 19:36:55 +0100 (BST) Received: by erda.amd.com (Postfix, from userid 35569) id 19DE28014; Mon, 10 May 2010 20:36:55 +0200 (CEST) Date: Tue, 11 May 2010 04:54:00 -0000 From: Robert Richter To: Arnaldo Carvalho de Melo CC: Masami Hiramatsu , Ingo Molnar , lkml , systemtap , Roland McGrath , DLE Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Message-ID: <20100510183654.GH6450@erda.amd.com> References: <20100510171207.26029.97604.stgit@localhost6.localdomain6> <20100510172854.GD30926@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20100510172854.GD30926@ghostprotocols.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: ausb3extmailp02.amd.com Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2010-q2/txt/msg00302.txt.bz2 On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote: > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu: > > Check elfutils version, and if it is old don't compile > > CFI analysis code. This allows to compile perf with > > old elfutils. > > _ELFUTILS_PREREQ was introduced in: > > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60 > Author: Roland McGrath > Date: Tue Dec 16 17:03:03 2008 -0800 > > Which was released in elfutils 0.138, guess this is coverage enough? > Richard, which version is in your machine? Right, this does not work, I am using 0.131. As expected, "_ELFUTILS_PREREQ" is not defined: gcc -o builtin-probe.o -c -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wformat-y2k -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement -fstack-protector-all -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iutil/include -Iarch/x86/include -I/usr/include/elfutils -DDWARF_SUPPORT -DNO_NEWT_SUPPORT -DNO_LIBPERL -DSHA1_HEADER='' builtin-probe.c In file included from builtin-probe.c:43: util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined util/probe-finder.h:47:21: error: missing binary operator before token "(" make: *** [builtin-probe.o] Error 1 Why not create a compile test as for NO_DWARF in tools/perf/Makefile? -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com