[Bug translator/11713] New: listing of available $variables should include $

[Bug translator/11713] New: listing of available $variables should include $

[fche at redhat dot com]

% stap -L 'kernel.function("sys_open")'
kernel.function("sys_open@fs/open.c:1050") $filename:char const* $flags:int
$mode:int $ret:long int

properly adds $ to the available $context variables being listed, but in
error messages, we don't decorate the variables that way.

% stap -p2 -e 'probe kernel.function("sys_open") {println($foo)}'
semantic error: unable to find local 'foo' near pc 0xffffffff810e1df7 in
sys_open(fs/open.c) (alternatives: filename flags mode ret): identifier '$foo'
at <input>:1:44

-- 
           Summary: listing of available $variables should include $
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P3
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11713] listing of available $variables should include $

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2010-06-18 03:14 -------
Created an attachment (id=4844)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4844&action=view)
patch

With this patch, the following message will be displayed,

$ ./stap -e 'probe kernel.function("sys_open"){print($foo)}'semantic error:
unable to find local 'foo' near pc 0xc04cf156 in sys_open(fs/open.c)
(alternatives: $filename $flags $mode $ret): identifier '$foo' at <input>:1:41
	source: probe kernel.function("sys_open"){print($foo)}
							^
Pass 2: analysis failed.  Try again with another '--vp 01' option.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11713] listing of available $variables should include $

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2010-06-18 10:59 -------
(In reply to comment #1)
> Created an attachment (id=4844)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4844&action=view)

Thanks.  I suspect there are a few other analogous places in the code.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11713] listing of available $variables should include $

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2010-06-21 06:32 -------
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=4844)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4844&action=view)
> 
> Thanks.  I suspect there are a few other analogous places in the code.
> 
Seems the patch is enough, It's hard-coded like $arg, $value for other probe types.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11713] listing of available $variables should include $

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2010-06-22 08:56 -------
commit 4ca5acc84095c947c2dfade905b8eab5a7433961
Author: Wenji Huang <wenji.huang@oracle.com>
Date:   Tue Jun 22 10:43:35 2010 +0800

    PR11713: listing available variable with leading '$'
    
    * dwflpp.cxx(dwflpp::print_locals): Add '$' to name.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11713] listing of available $variables should include $

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2010-06-22 13:05 -------
thanks

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11713

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.