* [Bug tapsets/11457] New: unresolved *mib_filter_key functions
@ 2010-03-30 22:46 jistone at redhat dot com
2010-04-21 15:14 ` [Bug tapsets/11457] " wenji dot huang at oracle dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: jistone at redhat dot com @ 2010-03-30 22:46 UTC (permalink / raw)
To: systemtap
There are three filter functions that are expected to be provided by the user:
linuxmib_filter_key(sk,op)
ipmib_filter_key(skb,op,SourceIsLocal)
tcpmib_filter_key(sk,op)
$ ./run-stap -L '**?' >/dev/null
semantic error: unresolved arity-2 function: identifier 'linuxmib_filter_key' at
/home/jistone/systemtap/build/../tapset/linuxmib.stp:33:8
source: key = linuxmib_filter_key(sk,op);
^
semantic error: unresolved arity-3 function: identifier 'ipmib_filter_key' at
/home/jistone/systemtap/build/../tapset/ipmib.stp:326:8
source: key = ipmib_filter_key(skb,op,SourceIsLocal);
^
...
We should at least provide *some* default implementations, even if users will
usually want to customize them. This could be done the same way
__indent_timestamp() is provided in indent-default.stp.
(I would eventually like "stap -L '**?'" to be a regular test...)
--
Summary: unresolved *mib_filter_key functions
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: jistone at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=11457
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/11457] unresolved *mib_filter_key functions
2010-03-30 22:46 [Bug tapsets/11457] New: unresolved *mib_filter_key functions jistone at redhat dot com
@ 2010-04-21 15:14 ` wenji dot huang at oracle dot com
2010-04-21 15:37 ` wenji dot huang at oracle dot com
2010-07-12 15:02 ` wcohen at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: wenji dot huang at oracle dot com @ 2010-04-21 15:14 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2010-04-21 06:18 -------
(In reply to comment #0)
>
> We should at least provide *some* default implementations, even if users will
> usually want to customize them. This could be done the same way
> __indent_timestamp() is provided in indent-default.stp.
>
Yes, to make building test pass, there are some implementations of such
*mib_filter_key functions. How about to move them to tapset?
>
> (I would eventually like "stap -L '**?'" to be a regular test...)
Agreed.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11457
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/11457] unresolved *mib_filter_key functions
2010-03-30 22:46 [Bug tapsets/11457] New: unresolved *mib_filter_key functions jistone at redhat dot com
2010-04-21 15:14 ` [Bug tapsets/11457] " wenji dot huang at oracle dot com
@ 2010-04-21 15:37 ` wenji dot huang at oracle dot com
2010-07-12 15:02 ` wcohen at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: wenji dot huang at oracle dot com @ 2010-04-21 15:37 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2010-04-21 06:20 -------
(In reply to comment #1)
> (In reply to comment #0)
> >
> > We should at least provide *some* default implementations, even if users will
> > usually want to customize them. This could be done the same way
> > __indent_timestamp() is provided in indent-default.stp.
> >
>
> Yes, to make building test pass, there are some implementations of such
> *mib_filter_key functions. How about to move them to tapset?
More clear, see testsuite/buildok/*mib-all-probes.stp
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11457
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/11457] unresolved *mib_filter_key functions
2010-03-30 22:46 [Bug tapsets/11457] New: unresolved *mib_filter_key functions jistone at redhat dot com
2010-04-21 15:14 ` [Bug tapsets/11457] " wenji dot huang at oracle dot com
2010-04-21 15:37 ` wenji dot huang at oracle dot com
@ 2010-07-12 15:02 ` wcohen at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: wcohen at redhat dot com @ 2010-07-12 15:02 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wcohen at redhat dot com 2010-07-12 15:02 -------
The following commits should address this:
78af6aa67f596e7f13b7c3ce5ab134a631fbdc8b
549d93ad41187c4d4c2b302fbea0b6adbecd4526
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=11457
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-12 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-30 22:46 [Bug tapsets/11457] New: unresolved *mib_filter_key functions jistone at redhat dot com
2010-04-21 15:14 ` [Bug tapsets/11457] " wenji dot huang at oracle dot com
2010-04-21 15:37 ` wenji dot huang at oracle dot com
2010-07-12 15:02 ` wcohen at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).