[Bug translator/11772] New: listing_mode_vars are empty with debuginfoless SDT

[Bug translator/11772] New: listing_mode_vars are empty with debuginfoless SDT

[jistone at redhat dot com]

As noted in bug 11769 comment 1, we rely on derived_probe::getargs() to list the
available args, but uprobe_derived_probe doesn't know about SDT's debuginfoless
$arg1, $arg2.  (Nor $$name or $$provider, for that matter).  The args still work
in a normal script though.

$ stap -L 'process("stap").mark("*")'process("stap").mark("cache__add__module")
process("stap").mark("cache__add__source")
process("stap").mark("cache__clean")
process("stap").mark("cache__get")
process("stap").mark("pass0__end")
process("stap").mark("pass0__start")
process("stap").mark("pass1__end")
process("stap").mark("pass1a__start")
process("stap").mark("pass1b__start")
process("stap").mark("pass2__end")
process("stap").mark("pass2__start")
process("stap").mark("pass3__end")
process("stap").mark("pass3__start")
process("stap").mark("pass4__end")
process("stap").mark("pass4__start")
process("stap").mark("pass5__end")
process("stap").mark("pass5__start")
process("stap").mark("pass6__end")
process("stap").mark("pass6__start")
process("stap").mark("stap_system__complete")
process("stap").mark("stap_system__spawn")
process("stap").mark("stap_system__start")

-- 
           Summary: listing_mode_vars are empty with debuginfoless SDT
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: jistone at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11772

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11772] listing_mode_vars are empty with debuginfoless SDT

[scox at redhat dot com]

------- Additional Comments From scox at redhat dot com  2010-07-26 21:50 -------
How about this?

--- a/tapsets.cxx
+++ b/tapsets.cxx
@@ -396,2 +396,3 @@ struct dwarf_derived_probe: public derived_probe
   void print_dupe_stamp(ostream& o);
+  void savesdtargs(int nargs);
 
@@ -3914,2 +3915,10 @@ dwarf_derived_probe::saveargs(dwarf_query& q, Dwarf_Die*
scope_die, dwarf_var_ex
 void
+dwarf_derived_probe::savesdtargs(int nargs)
+{
+  for (int i = 1; i <= nargs; i++)
+    args.push_back("$arg" + lex_cast (i) + ":long");
+}
+
+
+void
 dwarf_derived_probe::getargs(std::list<std::string> &arg_set) const
@@ -5111,2 +5120,3 @@ sdt_query::handle_query_module()
 					  q.statement_num_val, reloc_addr, q, 0);
+	      p->savesdtargs (arg_count);
 	      results.push_back (p);

stap -L 'process("../../install/bin/stap").mark("*")'
process("../../install/bin/stap").mark("cache__add__module") $arg1:long $arg2:long
process("../../install/bin/stap").mark("cache__add__source") $arg1:long $arg2:long
process("../../install/bin/stap").mark("cache__clean") $arg1:long
...


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |scox at redhat dot com
                   |redhat dot com              |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=11772

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.