[Bug tapsets/11951] New: Eliminate use of NIPQUAD and NIPQUAD_FMT in tapset/ip.stp

[Bug tapsets/11951] New: Eliminate use of NIPQUAD and NIPQUAD_FMT in tapset/ip.stp

[wcohen at redhat dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

The following networking examples fail with the 2.6.36-rcx kernels due to the
use of NIPQUAD and NIPQUAD_FMT:

FAIL: systemtap.examples/network/tcp_trace build
FAIL: systemtap.examples/network/tcp_trace run
FAIL: systemtap.examples/network/tcpdumplike build
FAIL: systemtap.examples/network/tcpdumplike run
FAIL: systemtap.examples/network/tcpipstat build
FAIL: systemtap.examples/network/tcpipstat run
FAIL: systemtap.examples/process/pfiles build
FAIL: systemtap.examples/process/pfiles run

All of them end up with an error:

 error: implicit declaration of function ‘NIPQUAD’

This is due to NIPQUAD and NIPQUAD_FMT being removed from the 2.6.36
kernels. One possibility is to just place the definitions for NIPQUAD
and NIPQUAD_FMT in tapset/ip.stp ip_ntop() function. However, that is
probably a fragile solution.

-- 
           Summary: Eliminate use of NIPQUAD and NIPQUAD_FMT in
                    tapset/ip.stp
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: wcohen at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11951

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/11951] Eliminate use of NIPQUAD and NIPQUAD_FMT in tapset/ip.stp

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-08-30 18:12 -------
Looks like the use of NIPQUAD/NIPQUAD_FMT was removed in the following kernel
commit:

  commit 3685f25de1b0447fff381c420de1e25bd57c9efb
  Author: Harvey Harrison <harvey.harrison@gmail.com>
  Date:   Fri Oct 31 00:56:49 2008 -0700

    misc: replace NIPQUAD()
    
    Using NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u
    can be replaced with %pI4

Then NIPQUAD/NIPQUAD_FMT was actually removed in:

  commit cf4ca4874fc45166198424384275f443a672d0b7
  Author: Joe Perches <joe@perches.com>
  Date:   Mon Aug 9 17:20:20 2010 -0700

    kernel.h: remove unused NIPQUAD and NIPQUAD_FMT
    
    There are no more uses of NIPQUAD or NIPQUAD_FMT.  Remove the definitions.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11951

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/11951] Eliminate use of NIPQUAD and NIPQUAD_FMT in tapset/ip.stp

[wcohen at redhat dot com]

------- Additional Comments From wcohen at redhat dot com  2010-08-31 16:09 -------
Certainly putting in definitions for NIPQUAD and NIPQUAD_FMT is possible.
commit 7225b04 fixes this.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11951

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.